| Summary: | Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Minh Ngo <nlminhtl> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, kevin, nlminhtl, notting, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | leechcraft-0.5.60-5.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-04-01 22:58:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Minh Ngo
2012-01-13 05:38:32 UTC
Offhand, I see a *lot* of sub-packages for plugins, which greatly adds complexity, for both packager (complicating .spec) and end-user (who's bombarded with an incredible number of choices about which ones to install. I hope you have good reason do want to do it this way? Wrt buildroot overrides, you can do it yourself via bodhi, https://admin.fedoraproject.org/updates/override/ I'm maintained these packages in openSUSE. And they are not very complexity for supporting. A end-user can read a description of a package and decide to install it. Every leechcraft package is a separate plugin that adds some functionality to the program. So they should not be in the single package. s/I'm maintained/I'm maintaining/ It looks indeed like that application is designed the Emacs way, where almost everything is a plugin… I think there should be some metapackage dragging in the whole package with all the plugins, like eclipse-platform, netbeans-platform, wine (as opposed to wine-core) etc. 0.4.98 Version with leechcraft-full metapackage SPEC: https://github.com/Ignotus/leechcraft-fedora/blob/ece5fa08481bc1122cea1d2887d4df22a52a3698/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/ece5fa08481bc1122cea1d2887d4df22a52a3698/leechcraft-0.4.98-1.fc16.src.rpm?raw=true Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3660003 0.4.98-2 SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/2f22b10881f0ad359f8571c25a234113c1289078/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/2f22b10881f0ad359f8571c25a234113c1289078/leechcraft-0.4.98-2.fc16.src.rpm?raw=true Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3701112 leechcraft-full metapackage fix SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/f6f532d51edb582e7949a9d7d16b7aa9ab056209/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/f6f532d51edb582e7949a9d7d16b7aa9ab056209/leechcraft-0.4.98-2.fc16.src.rpm?raw=true 0.4.98-3 Fixing the package leechcraft-acetamide name. Fixing the description for the main package. SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/c4067c7b838317585ae6f0f063e2c53364ab2c64/leechcraft.spec SRPM https://github.com/Ignotus/leechcraft-fedora/blob/c4067c7b838317585ae6f0f063e2c53364ab2c64/leechcraft-0.4.98-3.fc16.src.rpm?raw=true 0.4.99 Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3769978 SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/c12f03d04cdeb1269f962dbbf2909a5850f433cd/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/master/leechcraft-0.4.99-1.fc16.src.rpm?raw=true I was about to start review, but will be busy until at least the 20th, so I'll pick it up again then if no one beats me to it. 0.5.0 SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/efdbcc5891646c13aac1b5069842c1fad6be7ab8/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/master/leechcraft-0.5.0-1.fc16.src.rpm?raw=true BUILD: http://koji.fedoraproject.org/koji/taskinfo?taskID=3802820 OK, sorry for the delay.
1. Naming: mostly ok, but subpkg dependencies SHOULD be fully versioned, for example, instead of:
Requires: %{name}-iconset
use
Requires: %{name}-iconset = %{full_version}
and in -iconset-oxygen subpkg,
Provides: %{name}-iconset = %{full_version}
*unless*, you ever intend to provide alternative iconset's provided elsewhere? If so, then best leave off the versioning.
2. macros. SHOULD remove
%if "%{_lib}" == "lib64"
-DLIB_SUFFIX=64 \
%endif
snippet, default %{cmake} macro already includes that. see /etc/rpm/macros.cmake
3. scriptlets. MUST
main pkg, iconset-oxygen, iconset-tango are lacking icon-related scriptlets, see
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
4. qm translation files SHOULD be marked with %lang(locale) tags, but I'm not sure if that's practical here. if you can figure out a way to do that in an easy way, great. if not, don't worry about it.
Sources: ok
7daefb3130a475f9260eac069942076e leechcraft-0.5.0.tar.xz
Licensing: ok
most code is GPLv3+, sprinkled with some LGPLv2+ and GPLv2+, so combined result is indeed GPLv2+
Address items 1-4, and we're looking good.
As I understand the guidelines, proper handling of translations (point 4) is a MUST, not a SHOULD. You should just need multiple %find_lang --with-qt --without-mo calls at the end of %install. See how I did this in the Qt package itself: http://pkgs.fedoraproject.org/gitweb/?p=qt.git;a=blob;f=qt.spec;h=a90b1ce0f1f9fe175f0c9172cedc533351887145;hb=HEAD You should also be able to use %find_lang for the eiskaltdcpp translations instead of listing every language by hand. (And by the way, those are gettext translations, why aren't they in /usr/share/locale?) Kevin, translation files are not in the standard directory, so I can't find their with %find_lang macro. I don't know why they aren't in /usr/share/locale, but I can fix with something like:
root_dir=`echo ${RPM_BUILD_ROOT} | sed 's,\/,\\\/,g'`
find ${RPM_BUILD_ROOT}%{translations_dir} -name libeiskaltdcpp.mo | sed 's/^.*ions\/\([a-z]*\)\/LC.*/%lang(\1) \0/g;s/'$root_dir'//g' > libeiskaltdcpp.lang
0.5.0-2 SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/751542519992278037bca5a42e13f925d0fa46f5/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/751542519992278037bca5a42e13f925d0fa46f5/leechcraft-0.5.0-2.fc16.src.rpm?raw=true 0.5.0-3 SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/751542519992278037bca5a42e13f925d0fa46f5/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/751542519992278037bca5a42e13f925d0fa46f5/leechcraft-0.5.0-2.fc16.src.rpm?raw=true I'm sorry. There are incorrect version. 0.5.0-3 SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/29633e695014f4f50800b4e5d1bfe614a316ce57/leechcraft.spec SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/master/leechcraft-0.5.0-3.fc16.src.rpm?raw=true Well, a minor nit... if you aren't shipping alternative iconsets (ie, tango has been remove), why bother splitting out oxygen-iconset at all? think about it. :) Anyway, my other issues have been resolved, APPROVED. New Package SCM Request ======================= Package Name: leechcraft Short Description: LeechCraft internet client Owners: ignotusp Branches: f15 f16 el6 InitialCC: Git done (by process-git-requests). Added f17. leechcraft-0.5.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.0-3.fc16 leechcraft-0.5.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.0-3.fc15 leechcraft-0.5.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/leechcraft-0.5.0-4.fc17 leechcraft-0.5.0-3.fc16 has been pushed to the Fedora 16 testing repository. leechcraft-0.5.60-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-1.fc17 leechcraft-0.5.60-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-2.fc15 leechcraft-0.5.60-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-2.fc16 leechcraft-0.5.60-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-3.fc16 leechcraft-0.5.60-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-3.fc15 leechcraft-0.5.60-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-5.fc17 leechcraft-0.5.60-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-5.fc15 leechcraft-0.5.60-5.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. leechcraft-0.5.60-5.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. Please unretired f17 f18 branches This requires a re-review. |