Spec URL: https://raw.github.com/Ignotus/qxmpp-fedora/7f46c9159093e9228d35d829db4da91aa736c8a9/qxmpp-dev.spec SRPM URL: https://github.com/Ignotus/qxmpp-fedora/blob/7f46c9159093e9228d35d829db4da91aa736c8a9/qxmpp-dev-0.3.45.1-3.fc16.src.rpm?raw=true Description: QXmpp is a cross-platform C++ XMPP client library. It is based on Qt and C++. QXmpp is pretty intuitive and easy to use. It uses Qt extensively. Qt is the only third party library it is dependent on. Users need to a have working knowledge of C++ and Qt basics (Signals and Slots and Qt data types). The underlying TCP socket and the XMPP RFCs (RFC3920 and RFC3921) have been encapsulated into classes and functions. Therefore the user would not be bothered with these details. But it is always recommended to the advanced users to read and enjoy the low level details. This package's the fork of QXmpp. It introduces some new features to QXmpp core, like in-band registration and extended API. Some additional XEPs were also introduced, like XHTML-IM, Attention requests, Delivery receipts, etc. It's used for LeechCraft Internet Client (http://leechcraft.org/). SPEC file for it's already completed too https://github.com/Ignotus/leechcraft-fedora.
I'm putting this on the kde-reviews tracker, given that this is Qt stuff. I'm also clearing the fedora-review flag: According to our process, this should be set by the reviewer, not the submitter.
OK, here's an initial review : 1. -devel MUST depend on main pkg. add to -devel Requires: %{name}%{?_isa} = %{version}-%{release} 2. SHOULD track ABI, replace %{_libdir}/lib%{name}.so.* with %{_libdir}/libqxmpp-dev.so.2 (or whatever the proper soname is). 3. SHOULD: better to patch/fix lib64 handling properly, instead of current hack: %ifarch x86_64 %__mv ${RPM_BUILD_ROOT}/usr/{lib,lib64} %endif if you can't patch, this is better, %if "%{_lib}" = "lib64" ... %endif (there's more platforms using lib64 than just x86_64) 4. SHOULD use BuildRequires: qt4-devel (instead of qt-devel) 5. MUST fix -devel summary/description to reference qxmpp-dev instead of qxmpp
Fixed SRPM: https://github.com/Ignotus/qxmpp-fedora/blob/a76e05b841b02d6a34ac0af48c7d3f56ce57c60e/qxmpp-dev-0.3.45.1-4.fc16.src.rpm?raw=true SPEC: https://github.com/Ignotus/qxmpp-fedora/blob/a76e05b841b02d6a34ac0af48c7d3f56ce57c60e/qxmpp-dev.spec
naming: ok scriptlets: ok sources: ok md5sum *.bz2 9498edd097631d321d48b12f8ad99da1 qxmpp-0.3.45.1-extras.tar.bz2 macros: ok licensing: ok looks good, APPROVED.
Need to provide the information listed here, http://fedoraproject.org/wiki/Package_SCM_admin_requests in addition to seeing the fedora-cvs flag.
New Package SCM Request ======================= Package Name: qxmpp-dev Short Description: Qt XMPP Library Owners: ignotusp Branches: f15 f16 el6 InitialCC:
Git done (by process-git-requests).
qxmpp-dev-0.3.45.1-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/qxmpp-dev-0.3.45.1-4.fc15
qxmpp-dev-0.3.45.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/qxmpp-dev-0.3.45.1-4.fc16
qxmpp-dev-0.3.45.1-4.fc16 has been pushed to the Fedora 16 testing repository.
qxmpp-dev-0.3.45.1-4.fc15 has been pushed to the Fedora 15 stable repository.
qxmpp-dev-0.3.45.1-4.fc16 has been pushed to the Fedora 16 stable repository.
qxmpp-dev-0.3.45.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/qxmpp-dev-0.3.45.2-1.fc16
qxmpp-dev-0.3.45.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/qxmpp-dev-0.3.45.2-1.fc15
qxmpp-dev-0.3.45.2-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
qxmpp-dev-0.3.45.2-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
qxmpp-dev-0.3.45.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/qxmpp-dev-0.3.45.2-1.fc17
qxmpp-dev-0.3.47-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/qxmpp-dev-0.3.47-1.fc17
qxmpp-dev-0.3.47-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.