Bug 783268
| Summary: | Review Request: goffice08 - Goffice support libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bill Nottingham <notting> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bdpepple, notting, package-review, rvokal, volker27 |
| Target Milestone: | --- | Flags: | bdpepple:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | goffice08-0.8.17-4.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-08 06:03:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Bill Nottingham
2012-01-19 20:11:30 UTC
Requires: %{name} = %{version}-%{release} should have "isa".
You can drop defattr.
%{_datadir}/gtk-doc/html/goffice-0.8/ should be marked as documentation, I guess.
BUGS and MAINTAINERS could be included as documentation.
"gnome" as mentioned is in the description should probably start with a capital letter, being a name.
goffice08.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 17)
goffice08.src: W: invalid-url Source0: http://ftp.gnome.org/pub/gnome/sources/goffice/0.8.17/goffice-0.8.17.tar.xz HTTP Error 404: Not Found
http://ftp.gnome.org/pub/gnome/sources/goffice/0.8/goffice-0.8.17.tar.xz works
Rpmlint warns about wrong FSF address, but that is pretty minor, given the whole GPLv2/+ issue.
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3720752
Spec updated, same place.
Fixed:
- spaces&tabs
- source URL
- %doc for gtk-doc files
- added BUGS & MAINTAINERS
- GNOME in description fixed
- %{_isa} added
Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * Builds fine in mock. * Doesn't contain any .la libtool archives. Minor: * rpmlint output on that isn't a blocker: goffice08.x86_64: W: spelling-error Summary(en_US) Goffice -> Office, G office, Goff ice goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-color.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/component/goffice-component.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-calendar-button.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-pixmaps.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-stack.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-format-sel.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-text.h Bad: * Fails to build in Rawhide, but it looks like it's due to an issue with the version of PCRE there. I don't consider this a blocker, since it builds fine in F17, and I trust that you'll track down the problem in Rawhide. Here is a link to my rawhide scratch build. https://koji.fedoraproject.org/koji/taskinfo?taskID=3833918 +1 Package Approved. New Package SCM Request ======================= Package Name: goffice08 Short Description: Goffice support libraries Owners: notting Branches: f17 InitialCC: Git done (by process-git-requests). goffice08-0.8.17-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/goffice08-0.8.17-4.fc17 Package goffice08-0.8.17-4.fc17, gnucash-2.4.10-1.fc17, ktoblzcheck-1.37-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing goffice08-0.8.17-4.fc17 gnucash-2.4.10-1.fc17 ktoblzcheck-1.37-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-2822/gnucash-2.4.10-1.fc17,goffice08-0.8.17-4.fc17,ktoblzcheck-1.37-1.fc17 then log in and leave karma (feedback). goffice08-0.8.17-4.fc17, gnucash-2.4.10-1.fc17, ktoblzcheck-1.37-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |