Spec URL: http://notting.fedorapeople.org/review/goffice08.spec SRPM URL: http://notting.fedorapeople.org/review/goffice08-0.8.17-4.fc17.src.rpm Description: Support libraries for gnome office This is the prior version of GOffice that still uses GTK2, for apps that need it. For reference, diff to goffice spec file for that version: --- goffice.spec 2012-01-19 15:06:50.192698556 -0500 +++ goffice08.spec 2012-01-19 15:05:23.620696142 -0500 @@ -1,18 +1,20 @@ -Name: goffice +%define realname goffice + +Name: goffice08 Version: 0.8.17 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Goffice support libraries Group: System Environment/Libraries # bug filed upstream about this being GPL v2 only: # http://bugzilla.gnome.org/show_bug.cgi?id=463248 License: GPLv2 URL: http://freshmeat.net/projects/goffice/ -Source0: http://ftp.gnome.org/pub/gnome/sources/%{name}/%{version}/%{name}-%{version}.tar.xz - +Source0: http://ftp.gnome.org/pub/gnome/sources/%{realname}/%{version}/%{realname}-%{version}.tar.xz BuildRequires: libgsf-gnome-devel >= 1.13.3 BuildRequires: libgnomeui-devel >= 2.0.0 BuildRequires: intltool gettext BuildRequires: pcre-devel pcre-tools +Provides: %{realname} = %{version}-%{release} %description Support libraries for gnome office @@ -25,13 +27,15 @@ Requires: libgsf-gnome-devel >= 1.13.3 Requires: libgnomeui-devel >= 2.0.0 Requires: pkgconfig +Provides: %{realname}-devel = %{version}-%{release} %description devel Development libraries for goffice +Use goffice08 if your goffice application is built against GTK2. %prep -%setup -q +%setup -q -n %{realname}-%{version} %build @@ -45,7 +49,7 @@ make install DESTDIR=$RPM_BUILD_ROOT %find_lang goffice-%{version} rm $RPM_BUILD_ROOT/%{_libdir}/*.la -rm $RPM_BUILD_ROOT/%{_libdir}/%{name}/%{version}/plugins/*/*.la +rm $RPM_BUILD_ROOT/%{_libdir}/%{realname}/%{version}/plugins/*/*.la %post -p /sbin/ldconfig @@ -69,6 +73,9 @@ %changelog +* Thu Jan 19 2012 Bill Nottingham <notting> - 0.8.17-4 +- mangle into a compat package + * Tue Dec 6 2011 Peter Robinson <pbrobinson> -0.8.17-3 - add pcre-devel and pcre-tools
Requires: %{name} = %{version}-%{release} should have "isa". You can drop defattr. %{_datadir}/gtk-doc/html/goffice-0.8/ should be marked as documentation, I guess. BUGS and MAINTAINERS could be included as documentation. "gnome" as mentioned is in the description should probably start with a capital letter, being a name. goffice08.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 17) goffice08.src: W: invalid-url Source0: http://ftp.gnome.org/pub/gnome/sources/goffice/0.8.17/goffice-0.8.17.tar.xz HTTP Error 404: Not Found http://ftp.gnome.org/pub/gnome/sources/goffice/0.8/goffice-0.8.17.tar.xz works Rpmlint warns about wrong FSF address, but that is pretty minor, given the whole GPLv2/+ issue. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3720752
Spec updated, same place. Fixed: - spaces&tabs - source URL - %doc for gtk-doc files - added BUGS & MAINTAINERS - GNOME in description fixed - %{_isa} added
Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * Builds fine in mock. * Doesn't contain any .la libtool archives. Minor: * rpmlint output on that isn't a blocker: goffice08.x86_64: W: spelling-error Summary(en_US) Goffice -> Office, G office, Goff ice goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-color.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/component/goffice-component.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-calendar-button.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-pixmaps.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-stack.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-format-sel.h goffice08-devel.x86_64: E: incorrect-fsf-address /usr/include/libgoffice-0.8/goffice/gtk/go-action-combo-text.h Bad: * Fails to build in Rawhide, but it looks like it's due to an issue with the version of PCRE there. I don't consider this a blocker, since it builds fine in F17, and I trust that you'll track down the problem in Rawhide. Here is a link to my rawhide scratch build. https://koji.fedoraproject.org/koji/taskinfo?taskID=3833918 +1 Package Approved.
New Package SCM Request ======================= Package Name: goffice08 Short Description: Goffice support libraries Owners: notting Branches: f17 InitialCC:
Git done (by process-git-requests).
goffice08-0.8.17-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/goffice08-0.8.17-4.fc17
Package goffice08-0.8.17-4.fc17, gnucash-2.4.10-1.fc17, ktoblzcheck-1.37-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing goffice08-0.8.17-4.fc17 gnucash-2.4.10-1.fc17 ktoblzcheck-1.37-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-2822/gnucash-2.4.10-1.fc17,goffice08-0.8.17-4.fc17,ktoblzcheck-1.37-1.fc17 then log in and leave karma (feedback).
goffice08-0.8.17-4.fc17, gnucash-2.4.10-1.fc17, ktoblzcheck-1.37-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.