Bug 7836

Summary: options structure considered harmful
Product: [Retired] Red Hat Linux Reporter: David Lawrence <dkl>
Component: tmpwatchAssignee: Preston Brown <pbrown>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2000-01-18 16:59:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Derek Tattersall 1999-12-16 12:22:33 UTC 
The following mail appeared on devel-list.  I am including it here because
it exhibits a bug and part of the fix.

Notice the spelling of the option "mtiem" should be "mtime".

To: redhat-devel-list@redhat.com
Subject: tmpwatch 2.0 patch
From: Vandoorselaere Yoann <yoann@mandrakesoft.com>
Date: 15 Dec 1999 18:17:18 +0100 (Wed 12:17 EST)

Hi,

When passing an unknow option to tmpwatch it sigsegv,
this is due to the struct options used by getopt_long not terminated by
NULL;

Here is the patch :

--- tmpwatch.c.orig     Wed Dec 15 16:26:00 1999
+++ tmpwatch.c  Wed Dec 15 16:26:31 1999
@@ -271,6 +271,7 @@
     { "quiet", 0, 0, 'q' },
     { "atime", 0, 0, GETOPT_ATIME },
     { "mtiem", 0, 0, GETOPT_MTIME },
+    { 0, 0, 0, 0 }
   };

   if (argc == 1) usage();



see you

--
                   -- Yoann,  http://www.security-addict.org
Comment 1 Preston Brown 2000-01-18 16:59:59 UTC 
fixed in next release.