Bug 7836 - options structure considered harmful
Summary: options structure considered harmful
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: tmpwatch
Version: 6.1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Preston Brown
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 1999-12-16 12:22 UTC by David Lawrence
Modified: 2008-05-01 15:37 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2000-01-18 16:59:58 UTC


Attachments (Terms of Use)

Description Derek Tattersall 1999-12-16 12:22:33 UTC
The following mail appeared on devel-list.  I am including it here because
it exhibits a bug and part of the fix.

Notice the spelling of the option "mtiem" should be "mtime".

To: redhat-devel-list@redhat.com
Subject: tmpwatch 2.0 patch
From: Vandoorselaere Yoann <yoann@mandrakesoft.com>
Date: 15 Dec 1999 18:17:18 +0100 (Wed 12:17 EST)

Hi,

When passing an unknow option to tmpwatch it sigsegv,
this is due to the struct options used by getopt_long not terminated by
NULL;

Here is the patch :

--- tmpwatch.c.orig     Wed Dec 15 16:26:00 1999
+++ tmpwatch.c  Wed Dec 15 16:26:31 1999
@@ -271,6 +271,7 @@
     { "quiet", 0, 0, 'q' },
     { "atime", 0, 0, GETOPT_ATIME },
     { "mtiem", 0, 0, GETOPT_MTIME },
+    { 0, 0, 0, 0 }
   };

   if (argc == 1) usage();



see you

--
                   -- Yoann,  http://www.security-addict.org

Comment 1 Preston Brown 2000-01-18 16:59:59 UTC
fixed in next release.


Note You need to log in before you can comment on or make changes to this bug.