| Summary: | Missing dependency on pciutils | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominic Cleal <dcleal> |
| Component: | facter | Assignee: | Todd Zullinger <tmz> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 16 | CC: | rrati, tmz, vanmeeuwen+fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | facter-1.6.5-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-14 08:59:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Dominic Cleal
2012-01-22 08:59:44 UTC
Good catch Dominic. I'll add this to the spec file for the next release. 1.6.5 isn't be too far away. Did you report this upstream as well? If not, I can do that and send a patch for folks using the packages directly from puppetlabs.com or building their own.
I looked through the code for other commands that are executed via Facter::Util::Resolution.exec¹ and I think we're in pretty good shape. We don't require redhat-lsb so we're missing lsb_release, but that's intentional. Maybe that's worth revisiting someday. I haven't checked how much redhat-lsb drags in recently.
There are commands like arp, dnsdomainname, hostname, and ifconfig from net-tools that are used, but it seems like i would be hard to install a system without that. Thoughts on whether we should be explicitly requiring it are welcome.
¹ I didn't look for all the places where %x{} is used. There are still some of
those lurking.
(In reply to comment #1) > Good catch Dominic. I'll add this to the spec file for the next release. > 1.6.5 isn't be too far away. Did you report this upstream as well? If not, I > can do that and send a patch for folks using the packages directly from > puppetlabs.com or building their own. Good point, I've created http://projects.puppetlabs.com/issues/12077 > I looked through the code for other commands that are executed via > Facter::Util::Resolution.exec¹ and I think we're in pretty good shape. We > don't require redhat-lsb so we're missing lsb_release, but that's intentional. > Maybe that's worth revisiting someday. I haven't checked how much redhat-lsb > drags in recently. It's not as bad as it was on EL6, and while I know lack of lsb* catches a few people out, I think facter's better off not requiring LSB. > There are commands like arp, dnsdomainname, hostname, and ifconfig from > net-tools that are used, but it seems like i would be hard to install a system > without that. Thoughts on whether we should be explicitly requiring it are > welcome. initscripts, openvpn, libguestfs all depend on net-tools so it seems reasonable to add it, I can't see that it does any harm. facter-1.6.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/facter-1.6.5-1.fc15 facter-1.6.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/facter-1.6.5-1.fc16 facter-1.6.5-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/facter-1.6.5-1.el5 facter-1.6.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/facter-1.6.5-1.el6 Package facter-1.6.5-1.el5: * should fix your issue, * was pushed to the Fedora EPEL 5 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing facter-1.6.5-1.el5' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-0263/facter-1.6.5-1.el5 then log in and leave karma (feedback). facter-1.6.5-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. facter-1.6.5-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. facter-1.6.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. facter-1.6.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |