Bug 783749 - Missing dependency on pciutils
Summary: Missing dependency on pciutils
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: facter
Version: 16
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Todd Zullinger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-22 08:59 UTC by Dominic Cleal
Modified: 2012-02-15 01:21 UTC (History)
3 users (show)

Fixed In Version: facter-1.6.5-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-14 08:59:10 UTC
Type: ---


Attachments (Terms of Use)

Description Dominic Cleal 2012-01-22 08:59:44 UTC
Description of problem:
Facter uses 'lspci' for the detection of many hypervisors, as well as dmidecode.  The facter package should depend on pciutils to ensure this functionality is complete.

Version-Release number of selected component (if applicable):
1.6.4

Comment 1 Todd Zullinger 2012-01-22 20:54:36 UTC
Good catch Dominic.  I'll add this to the spec file for the next release.  1.6.5 isn't be too far away.  Did you report this upstream as well?  If not, I can do that and send a patch for folks using the packages directly from puppetlabs.com or building their own.

I looked through the code for other commands that are executed via Facter::Util::Resolution.exec¹ and I think we're in pretty good shape.  We don't require redhat-lsb so we're missing lsb_release, but that's intentional.  Maybe that's worth revisiting someday.  I haven't checked how much redhat-lsb drags in recently.

There are commands like arp, dnsdomainname, hostname, and ifconfig from net-tools that are used, but it seems like i would be hard to install a system without that.  Thoughts on whether we should be explicitly requiring it are welcome.

¹ I didn't look for all the places where %x{} is used.  There are still some of
those lurking.

Comment 2 Dominic Cleal 2012-01-22 23:30:19 UTC
(In reply to comment #1)
> Good catch Dominic.  I'll add this to the spec file for the next release. 
> 1.6.5 isn't be too far away.  Did you report this upstream as well?  If not, I
> can do that and send a patch for folks using the packages directly from
> puppetlabs.com or building their own.

Good point, I've created http://projects.puppetlabs.com/issues/12077

> I looked through the code for other commands that are executed via
> Facter::Util::Resolution.exec¹ and I think we're in pretty good shape.  We
> don't require redhat-lsb so we're missing lsb_release, but that's intentional. 
> Maybe that's worth revisiting someday.  I haven't checked how much redhat-lsb
> drags in recently.

It's not as bad as it was on EL6, and while I know lack of lsb* catches a few people out, I think facter's better off not requiring LSB.

> There are commands like arp, dnsdomainname, hostname, and ifconfig from
> net-tools that are used, but it seems like i would be hard to install a system
> without that.  Thoughts on whether we should be explicitly requiring it are
> welcome.

initscripts, openvpn, libguestfs all depend on net-tools so it seems reasonable to add it, I can't see that it does any harm.

Comment 3 Fedora Update System 2012-01-26 16:46:15 UTC
facter-1.6.5-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/facter-1.6.5-1.fc15

Comment 4 Fedora Update System 2012-01-26 16:46:24 UTC
facter-1.6.5-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/facter-1.6.5-1.fc16

Comment 5 Fedora Update System 2012-01-26 16:46:34 UTC
facter-1.6.5-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/facter-1.6.5-1.el5

Comment 6 Fedora Update System 2012-01-26 16:46:43 UTC
facter-1.6.5-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/facter-1.6.5-1.el6

Comment 7 Fedora Update System 2012-01-27 19:18:55 UTC
Package facter-1.6.5-1.el5:
* should fix your issue,
* was pushed to the Fedora EPEL 5 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing facter-1.6.5-1.el5'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-0263/facter-1.6.5-1.el5
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2012-02-14 08:59:10 UTC
facter-1.6.5-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2012-02-14 09:12:35 UTC
facter-1.6.5-1.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2012-02-15 01:21:04 UTC
facter-1.6.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2012-02-15 01:21:20 UTC
facter-1.6.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.