Bug 784613
| Summary: | Review Request: python-auth-credential - abstraction of a credential | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Massimo Paladin <massimo.paladin> |
| Component: | Package Review | Assignee: | Steve Traylen <steve.traylen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, steve.traylen, tomspur |
| Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-auth-credential-0.5-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-08 04:57:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Massimo Paladin
2012-01-25 15:04:19 UTC
Your spec file looks quite fine so far.
Could you please be more specific in %files, so you know when egg-building failed?
e.g.:
%{python_sitelib}/%{name}-%{version}-py?.?.egg-info
%{python_sitelib}/%{name}/
etc.
Have you done other informal reviews yet? Please link them here.
For more information see:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Reviewing_packages
Hi Thomas, I changed the %files section to be more specific as you requested. I haven't done any informal review so far, as soon as I will do one I will post it here. Massimo, When changing the package as per Thomas's comments can you generate an new rpm and spec file increasing the release number of the package, see: .. there's a link that explains this I can't find at the moment... Steve. 3rd bullet point on: https://fedoraproject.org/wiki/Packaging_tricks#Recommendations_for_review_requests this page has lots of "good stuff". Steve. Steve, sorry for not increasing the release tag, I thought it was permitted before approving the package. One question, I actually changed the spec file and I also reverted back for the following reason. I would like that the package reach EPEL5, in rhel5 and python 2.4 the egg-info file is not created. How would you recommend to proceed in such case? So I can believe the egg file is not created in EPEL5. Use a dist tag condition to case the file in the %files section: http://fedoraproject.org/wiki/Packaging:DistTag Concerning this more precise %files recommended here then this also applies to the other package of yours as well in #784603. Steve. Steve, package updated: https://mpaladin.web.cern.ch/mpaladin/rpms/python-auth-credential/python-auth-credential.spec https://mpaladin.web.cern.ch/mpaladin/rpms/python-auth-credential/python-auth-credential-0.5-2.fc16.src.rpm Hi what is your FAS id? Hi Steve, my FAS id is mpaladin: https://admin.fedoraproject.org/accounts/user/view/mpaladin Approved , you should be able to procede with an scm request next. New Package SCM Request ======================= Package Name: python-auth-credential Short Description: Python abstraction of a credential Owners: mpaladin Branches: f16 f17 el5 el6 InitialCC: Git done (by process-git-requests). python-auth-credential-0.5-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.fc17 python-auth-credential-0.5-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.fc16 python-auth-credential-0.5-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.el5 python-auth-credential-0.5-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.el6 python-auth-credential-0.5-2.fc17 has been pushed to the Fedora 17 testing repository. python-auth-credential-0.5-2.fc16 has been pushed to the Fedora 16 stable repository. python-auth-credential-0.5-2.fc17 has been pushed to the Fedora 17 stable repository. python-auth-credential-0.5-2.el6 has been pushed to the Fedora EPEL 6 stable repository. python-auth-credential-0.5-2.el5 has been pushed to the Fedora EPEL 5 stable repository. |