Bug 784613 - Review Request: python-auth-credential - abstraction of a credential
Summary: Review Request: python-auth-credential - abstraction of a credential
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Steve Traylen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-25 15:04 UTC by Massimo Paladin
Modified: 2012-03-08 17:27 UTC (History)
4 users (show)

Fixed In Version: python-auth-credential-0.5-2.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-08 04:57:28 UTC
Type: ---
Embargoed:
steve.traylen: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Massimo Paladin 2012-01-25 15:04:19 UTC
Spec URL: https://mpaladin.web.cern.ch/mpaladin/rpms/python-auth-credential/python-auth-credential.spec
SRPM URL: https://mpaladin.web.cern.ch/mpaladin/rpms/python-auth-credential/python-auth-credential-0.5-1.fc16.src.rpm
Description:
This module offers an abstraction of a credential, i.e. something that
can be used to authenticate. It allows the creation and manipulation of
credentials. In particular, it defines a standard string representation
(so that credentials can be given to external programs as command line
options), a standard structured representation (so that credentials can
be stored in structured configuration files or using JSON) and
"preparators" that can transform credentials into ready-to-use data for
well known targets.

The python module auth.credential is compatible with the Perl
module Authen::Credential.

Comment 1 Thomas Spura 2012-01-27 03:25:41 UTC
Your spec file looks quite fine so far.

Could you please be more specific in %files, so you know when egg-building failed?
e.g.:
%{python_sitelib}/%{name}-%{version}-py?.?.egg-info
%{python_sitelib}/%{name}/
etc.

Have you done other informal reviews yet? Please link them here.
For more information see:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Reviewing_packages

Comment 2 Massimo Paladin 2012-01-27 08:44:35 UTC
Hi Thomas,

I changed the %files section to be more specific as you requested.

I haven't done any informal review so far, as soon as I will do one I will post it here.

Comment 3 Steve Traylen 2012-02-19 12:02:11 UTC
Massimo,

When changing the package as per Thomas's comments can you generate an new
rpm and spec file increasing the release number of the package, see:

.. there's a link that explains this I can't find at the moment...

Steve.

Comment 4 Steve Traylen 2012-02-20 07:56:06 UTC
3rd bullet point on:

https://fedoraproject.org/wiki/Packaging_tricks#Recommendations_for_review_requests

this page has lots of "good stuff".

Steve.

Comment 5 Massimo Paladin 2012-02-20 08:13:01 UTC
Steve,
sorry for not increasing the release tag, I thought it was permitted before approving the package.

One question, I actually changed the spec file and I also reverted back for the following reason.
I would like that the package reach EPEL5, in rhel5 and python 2.4 the egg-info file is not created.

How would you recommend to proceed in such case?

Comment 6 Steve Traylen 2012-02-20 08:56:00 UTC
So I can believe the egg file is not created in EPEL5.

Use a dist tag condition to case the file in the %files section:

http://fedoraproject.org/wiki/Packaging:DistTag

Concerning this more precise %files recommended  here then this also applies to the other 
package of yours as well in #784603.

Steve.

Comment 8 Steve Traylen 2012-02-20 20:49:49 UTC
Hi what is your FAS id?

Comment 9 Massimo Paladin 2012-02-20 21:02:15 UTC
Hi Steve,

my FAS id is mpaladin:
https://admin.fedoraproject.org/accounts/user/view/mpaladin

Comment 10 Steve Traylen 2012-02-20 21:13:08 UTC
Approved , you should be able to procede with an scm request next.

Comment 11 Massimo Paladin 2012-02-21 07:56:47 UTC
New Package SCM Request
=======================
Package Name: python-auth-credential
Short Description: Python abstraction of a credential
Owners: mpaladin
Branches: f16 f17 el5 el6
InitialCC:

Comment 12 Gwyn Ciesla 2012-02-21 13:39:34 UTC
Git done (by process-git-requests).

Comment 13 Fedora Update System 2012-02-22 07:55:16 UTC
python-auth-credential-0.5-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.fc17

Comment 14 Fedora Update System 2012-02-22 07:56:36 UTC
python-auth-credential-0.5-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.fc16

Comment 15 Fedora Update System 2012-02-22 07:59:00 UTC
python-auth-credential-0.5-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.el5

Comment 16 Fedora Update System 2012-02-22 07:59:45 UTC
python-auth-credential-0.5-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-auth-credential-0.5-2.el6

Comment 17 Fedora Update System 2012-02-22 17:45:49 UTC
python-auth-credential-0.5-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 18 Fedora Update System 2012-03-08 04:57:28 UTC
python-auth-credential-0.5-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 19 Fedora Update System 2012-03-08 06:02:54 UTC
python-auth-credential-0.5-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 20 Fedora Update System 2012-03-08 17:26:32 UTC
python-auth-credential-0.5-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 21 Fedora Update System 2012-03-08 17:27:23 UTC
python-auth-credential-0.5-2.el5 has been pushed to the Fedora EPEL 5 stable repository.


Note You need to log in before you can comment on or make changes to this bug.