Bug 785488

Summary:	Review Request: php-horde-Horde-View - Horde View API
Product:	[Fedora] Fedora	Reporter:	Nick Bebout <nb>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, notting, package-review, shawn
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	NotReady
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-10 09:10:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nick Bebout 2012-01-29 04:08:10 UTC

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-View.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-View-1.0.1-1.fc16.src.rpm
Description: A simple View pattern implementation.

Comment 1 Shawn Iwinski 2012-06-23 14:52:55 UTC

I am not an official package reviewer, but here are some comments I have for this package:



*** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements



*** Your BuildRequires should be
BuildRequires:  php-pear(PEAR) >= 1.7.0
instead of
BuildRequires:  php-pear >= 1:1.4.9-1.2
(this would match what you have in bug 785606 and satisfy this package's package.xml dependency)



*** Per package.xml requirements, please add:
Requires: php-common >= 5.2.0



*** phpci results: For completeness, you may wish to require the virtual packages (and to prevent any future packaging issues due to PHP package changes) "php-date", "php-json", "php-pcre", "php-reflection", and "php-spl".



*** Up to you, but package.xml lists the following optional packages if you choose to require:
- php-pear(pear.horde.org/Horde_Controller) < 2.0.0
- php-pear(pear.horde.org/Horde_Routes) < 2.0.0
(if you do choose to require these packages, please update this ticket's "Depends On")



*** Please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag) -- I'm assuming no EPEL 5 build because your other php-horde-* packages do not.

Comment 2 Remi Collet 2013-02-10 09:10:39 UTC

I have updated / submit this one

*** This bug has been marked as a duplicate of bug 909662 ***