Bug 785491 (horde-injector)

Summary:	Review Request: php-horde-Horde-Injector - Horde dependency injection container
Product:	[Fedora] Fedora	Reporter:	Nick Bebout <nb>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, notting, package-review, shawn
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-10 08:59:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nick Bebout 2012-01-29 04:21:01 UTC

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector-1.0.1-1.fc16.src.rpm
Description: A depedency injection container for Horde.

Comment 1 Shawn Iwinski 2012-06-23 13:45:52 UTC

I am not an official package reviewer, but here are some comments I have for this package:



*** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements



*** Your BuildRequires should be
BuildRequires:  php-pear(PEAR) >= 1.7.0
instead of
BuildRequires:  php-pear >= 1:1.4.9-1.2
(this would match what you have in bug 785606 and satisfy this package's package.xml dependency)



*** Per package.xml requirements, please add:
Requires: php-common >= 5.2.0



*** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual packages "php-reflection" and "php-spl".

Comment 2 Nick Bebout 2012-06-25 16:28:46 UTC

I believe I have fixed these issues:

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector-1.0.1-2.fc16.src.rpm

Comment 3 Remi Collet 2013-02-10 08:59:19 UTC

I have updated and submit this one.

*** This bug has been marked as a duplicate of bug 909659 ***