Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector-1.0.1-1.fc16.src.rpm Description: A depedency injection container for Horde.
I am not an official package reviewer, but here are some comments I have for this package: *** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements *** Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** Per package.xml requirements, please add: Requires: php-common >= 5.2.0 *** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual packages "php-reflection" and "php-spl".
I believe I have fixed these issues: Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Injector-1.0.1-2.fc16.src.rpm
I have updated and submit this one. *** This bug has been marked as a duplicate of bug 909659 ***