Bug 787020
Summary: | Review Request: trafficserver - Apache Traffic Server | ||
---|---|---|---|
Product: | [Fedora] Fedora EPEL | Reporter: | Jan-Frode Myklebust <janfrode> |
Component: | Package Review | Assignee: | Kalpa Welivitigoda <callkalpa> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | el6 | CC: | bill-bugzilla.redhat.com, callkalpa, fedora-package-review, jdunn, leif, ming.zym |
Target Milestone: | --- | Flags: | callkalpa:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | trafficserver-3.0.4-4.fc17 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-04-08 17:04:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jan-Frode Myklebust
2012-02-02 22:32:54 UTC
*** Bug 683463 has been marked as a duplicate of this bug. *** Updated to v3.0.3 (release candidate): Spec URL: http://blag.tanso.net/code/ats/v3.0.3-0/trafficserver.spec SRPM URL: http://blag.tanso.net/code/ats/v3.0.2-0/trafficserver-3.0.3-0.el6.src.rpm Hi Jan, The link to rpm file is not working. Could you please fix it. Looks like it's just a typo in the URL: http://blag.tanso.net/code/ats/v3.0.3-0/trafficserver-3.0.3-0.el6.src.rpm works. rpmlint trafficserver.spec trafficserver-3.0.3-0.el6.src.rpm trafficserver.spec:5: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 5) trafficserver.src: W: spelling-error Summary(en_US) scalable -> salable, callable, calculable trafficserver.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable trafficserver.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 5) 1 packages and 1 specfiles checked; 0 errors, 4 warnings. Please correct the mixed-use-of-spaces-and-tabs The rest seems ok Fixed the mixed use of spaces and tabs: $ rpmlint trafficserver-3.0.3-1.el6.src.rpm trafficserver.src: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. http://blag.tanso.net/code/ats/v3.0.3-1/trafficserver.spec http://blag.tanso.net/code/ats/v3.0.3-1/trafficserver-3.0.3-1.el6.src.rpm The package is good to go New Package SCM Request ======================= Package Name: trafficserver Short Description: Apache Traffic Server is a fast, scalable and extensible HTTP/1.1 compliant caching proxy server. Owners: janfrode Branches: el5 el6 InitialCC: please hold for few days, as we will release 3.0.4 asap, for some important fix. I'll wait with submitting this package to EPEL until v3.0.4 is done, but this shouldn't hold back getting included in SCM. BTW Yongming, you should probably look into updating the News and Download sections of http://trafficserver.apache.org/. It's still claiming v3.0.2 is the latest stable release. Git done (by process-git-requests). Kalpa, please take ownership of review BZs. Thanks! Jon, I hope I have already done. If not could you please guide me? sorry. Now only I did it. Thanks Yongming, the build fails on ppc64 with the message #error "unsupported processor": http://koji.fedoraproject.org/koji/getfile?taskID=3884843&name=build.log is this something that can be fixed ? trafficserver-3.0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trafficserver-3.0.3-2.el6 trafficserver-3.0.3-2.el6 has been pushed to the Fedora EPEL 6 testing repository. trafficserver-3.0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trafficserver-3.0.3-3.el6 Bill, FYI: I fixed the proxy.config.proxy_name to default to FIXME.example.com (didn't want to mess with post install scripts for this), and pointed default proxy.config.ssl.server.cert.path and proxy.config.ssl.server.private_key.path to your suggested /etc/pki locations. Also have gotten upstream to change the initscript to use "traffic_line -x" on reloads, but this isn't included in this package (fixed in v3.1)... Jan-Frode, I was testing this package on Fedora 16 and the init script seems to hang, although the services are started properly and I can use trafficserver as a forward proxy. I'm not that familiar with this software, so can you give me some information about where I should start looking? This is what happens: demeter:/etc/trafficserver$ sudo systemctl start trafficserver.service <hangs until systemctl timeout is reached> Job failed. See system logs and 'systemctl status' for details. demeter:/etc/trafficserver$ sudo systemctl status trafficserver.service [sudo] password for jdunn: trafficserver.service - LSB: Startup/shutdown script for the Apache Traffic Server Loaded: loaded (/etc/rc.d/init.d/trafficserver) Active: failed since Wed, 21 Mar 2012 00:25:44 -0400; 17s ago Process: 1663 ExecStart=/etc/rc.d/init.d/trafficserver start (code=exited, status=0/SUCCESS) CGroup: name=systemd:/system/trafficserver.service ├ 1453 /usr/bin/traffic_cop ├ 1455 /usr/bin/traffic_manager └ 1467 /usr/bin/traffic_server -M -A,9:X and some relevant log file lines from /var/log/messages: Mar 21 00:20:44 demeter trafficserver[1663]: Starting Apache Traffic Server: [ OK ]#015[ OK ] Mar 21 00:20:44 demeter systemd[1]: PID file /var/run/trafficserver/cop.pid not readable (yet?) after start. Mar 21 00:25:44 demeter systemd[1]: trafficserver.service operation timed out. Terminating. Mar 21 00:25:44 demeter systemd[1]: Unit trafficserver.service entered failed state. Julian: thanks for testing on F16. Could you please try again with the following trafficserver.service ? ----8<------8<-----8<-------8<------8<-----8<-------8<------8<-----8<--- [Unit] Description=Apache Traffic Server is a fast, scalable and extensible caching proxy server. After=syslog.target network.target [Service] Type=simple EnvironmentFile=-/etc/sysconfig/trafficserver PIDFile=/var/run/trafficserver/cop.pid ExecStart=/usr/bin/traffic_cop $TC_DAEMON_ARGS ExecReload=/usr/bin/traffic_line -x [Install] WantedBy=multi-user.target ----8<------8<-----8<-------8<------8<-----8<-------8<------8<-----8<------ Thanks, that worked. I had to delete the SysV init script and drop this into /lib/systemd/system with a systemd --system daemon-reload for good measure. I guess you'll have to do some special handling in the package depending on whether it's running on Fedora or EPEL? Thanks for verifying that this worked. Much appreciated! I will fix the package to support fedora soon. Just wanted to get EL6 working first, since that's what I need myself. Package Change Request ====================== Package Name: trafficserver New Branches: f15 f16 f17 Owners: janfrode InitialCC: Git done (by process-git-requests). Julian, I implemented systemd support and launched a build for f16 at: http://koji.fedoraproject.org/koji/taskinfo?taskID=3917731 Maybe you could try that (once it's complete), and report if it works ? This build worked better.. http://koji.fedoraproject.org/koji/taskinfo?taskID=3920721 Thanks, it works great. I do notice though that /var/run/trafficserver/cop.pid never gets created, so systemd complains on reloads: Mar 21 19:53:14 demeter systemd[1]: PID file /var/run/trafficserver/cop.pid not readable (yet?) after reload. Not sure if that's a packaging problem or an upstream issue. Looks like a packaging problem... For sysv-initscripts the pidfile is created by the initscript, not by the daemon. Not sure how this should work with systemd. Looks like pidfile isn't needed for type=simple systemd services. I'll just remove it. trafficserver-3.0.3-6.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trafficserver-3.0.3-6.fc16 trafficserver-3.0.3-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trafficserver-3.0.3-6.el6 trafficserver-3.0.3-6.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/trafficserver-3.0.3-6.fc15 Works great now Jan-Frode. Thanks. BTW, a small typo in your package "Description" for the next update. It reads "Apache Traffic Server is fast, scalable and extensible HTTP/1.1 compliant caching proxy server." I think you need an "a" before the word "fast" trafficserver-3.0.4-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/trafficserver-3.0.4-1.fc15 trafficserver-3.0.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trafficserver-3.0.4-1.el6 trafficserver-3.0.4-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trafficserver-3.0.4-1.fc16 I've been a bit confused about that typo. Have assumes it was some advanced English, since that's the intro line http://trafficserver.apache.org has been using for quite some time.. I see now they've "fixed" it to definitely be wrong. You can file bugs, or even better, send patches you know ;-). I didn't break it the first time, I broke it good the last time. And now the build system is effed up, but I have corrected it again. Looking forward to see the packages on EPEL! I found another problem with this on Fedora 16, which is that after a server is rebooted, /var/run is recreated. Hence, trafficserver refuses to start up because /var/run/trafficserver is missing. I added this line to trafficserver.service to create the directory with the right permissions, but maybe it's not the most elegant. It works, though: ExecStartPre=/usr/bin/install -d -o root -g ats -m 775 /var/run/trafficserver One more thing: I think the EnvironmentFile line has a typo in it. It should be: EnvironmentFile=/etc/sysconfig/trafficserver (no leading dash to "/etc") Julian, according to http://fedoraproject.org/wiki/Packaging:Systemd the leading dash in EnvironmentFile should mean that no error messages are created if the file doesn't exist. So I think this is correct. Regarding the /var/run/trafficserver, I guess I'll have to create this using tmpfiles.d, ref: http://fedoraproject.org/wiki/Packaging:Tmpfiles.d trafficserver-3.0.4-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/trafficserver-3.0.4-2.fc15 trafficserver-3.0.4-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trafficserver-3.0.4-2.fc16 trafficserver-3.0.4-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trafficserver-3.0.4-2.el6 This trafficserver-3.0.4-2 release should fix the /var/run/trafficserver-creation on boot. trafficserver-3.0.4-2.el6 has been pushed to the Fedora EPEL 6 stable repository. trafficserver-3.0.4-2.fc15 has been pushed to the Fedora 15 stable repository. trafficserver-3.0.4-2.fc16 has been pushed to the Fedora 16 stable repository. trafficserver-3.0.4-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trafficserver-3.0.4-4.fc17 trafficserver-3.0.4-4.fc17 has been pushed to the Fedora 17 stable repository. |