Bug 787742

Summary: pwconv/grpconv skips 2nd of consecutive failures
Product: Red Hat Enterprise Linux 6 Reporter: Martin Poole <mpoole>
Component: shadow-utilsAssignee: Tomas Mraz <tmraz>
Status: CLOSED ERRATA QA Contact: Dalibor Pospíšil <dapospis>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2CC: dapospis, dcleal, mmalik, rpiddapa, rrajaram, tmraz
Target Milestone: rcKeywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: shadow-utils-4.1.4.2-14.el6 Doc Type: Bug Fix
Doc Text:
Cause: pwconv/grpconv improperly parsed shadow/gshadow files with errors. Consequence: When writing corrected shadow/gshadow files only first error on two consecutive erroneous lines was corrected. Fix: pwconv/grpconv now parses the files with errors correctly. Result: All lines are corrected in the newly written files.
 Story Points: ---
Clone Of: 787736
: 844280 (view as bug list) Environment:
Last Closed: 2014-10-14 07:16:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 787736, 832995    
Bug Blocks: 727267, 782183, 844280, 947775, 947782    
Attachments:
Description Flags
patch to avoid skiping entries none

Description Martin Poole 2012-02-06 16:08:04 UTC 
Created attachment 559672 [details]
patch to avoid skiping entries

+++ This bug was initially created as a clone of Bug #787736 +++

Created attachment 559668 [details]
patch to avoid skiping entries

Description of problem:

If /etc/shadow (or /etc/gshadow) contains consecutive bad lines pwconv only fixes the first, skipping the 2nd.


Version-Release number of selected component (if applicable):

shadow-utils-4.1.4.2-13.el6

How reproducible:

Always.

Steps to Reproduce:

echo 'example1:!!:15372:0:99999:7:::' >> /etc/shadow
echo 'example2:!!:15372:0:99999:7:::' >> /etc/shadow

pwck -r

pwconv

pwck -r

  
Actual results:

# echo 'example1:!!:15372:0:99999:7:::' >> /etc/shadow
# echo 'example2:!!:15372:0:99999:7:::' >> /etc/shadow

# pwck -r
no matching password file entry in /etc/passwd
delete line 'example1:!!:15372:0:99999:7:::'? No
no matching password file entry in /etc/passwd
delete line 'example2:!!:15372:0:99999:7:::'? No
pwck: no changes

# pwconv

# pwck -r
no matching password file entry in /etc/passwd
delete line 'example2:!!:15372:0:99999:7:::'? No
pwck: no changes

Expected results:

# echo 'example1:!!:15372:0:99999:7:::' >> /etc/shadow
# echo 'example2:!!:15372:0:99999:7:::' >> /etc/shadow

# pwck -r
no matching password file entry in /etc/passwd
delete line 'example1:!!:15372:0:99999:7:::'? No
no matching password file entry in /etc/passwd
delete line 'example2:!!:15372:0:99999:7:::'? No
pwck: no changes

# pwconv

# pwck -r
pwck: no changes


Additional info:

Problem is due to structure of layer fetch routines.  pwconv does a loop via spw_next()  and when it finds an error deletes the entry by name.

Unfortunately the delete routine checks whether a deleted item corresponds to the current fetch item and if so does an internal next, then the main loop runs and this subsequent entry is skipped.
Comment 1 RHEL Program Management 2012-07-10 06:22:42 UTC 
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.
Comment 2 RHEL Program Management 2012-07-11 01:58:04 UTC 
This request was erroneously removed from consideration in Red Hat Enterprise Linux 6.4, which is currently under development.  This request will be evaluated for inclusion in Red Hat Enterprise Linux 6.4.
Comment 4 Tom Lavigne 2012-09-18 15:26:24 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unable to address this
request at this time.
    
Red Hat invites you to ask your support representative to
propose this request, if appropriate, in the next release of
Red Hat Enterprise Linux.
Comment 7 RHEL Program Management 2013-10-14 00:48:23 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unable to address this
request at this time.

Red Hat invites you to ask your support representative to
propose this request, if appropriate, in the next release of
Red Hat Enterprise Linux.
Comment 11 errata-xmlrpc 2014-10-14 07:16:29 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1522.html