Bug 788338

Summary:	Resource leaks on virsh desc command
Product:	Red Hat Enterprise Linux 6	Reporter:	Alex Jia <ajia>
Component:	libvirt	Assignee:	Alex Jia <ajia>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.3	CC:	acathrow, dallan, dyuan, mshao, mzhan, rwu, veillard
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-0.9.10-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 06:48:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alex Jia 2012-02-08 05:02:06 UTC

Description of problem:
virsh desc has 1 leaked reference.

Version-Release number of selected component (if applicable):
# rpm -q libvirt
libvirt-0.9.10-0rc1.el6.x86_64


How reproducible:
always

Steps to Reproduce:
1. virsh desc <domain>
2.
3.
  
Actual results:
# virsh desc foo
No description for domain: foo
error: Failed to disconnect from the hypervisor, 1 leaked reference(s)


Expected results:
avoid resource leak.

Additional info:
my guest 'foo' originally hasn't any description.

Comment 1 Alex Jia 2012-02-08 05:58:48 UTC

The patch has been sent to upstream and wait for review:
https://www.redhat.com/archives/libvir-list/2012-February/msg00409.html

Comment 2 Alex Jia 2012-02-08 09:17:19 UTC

The patch has been ACKed and pushed, so move bug to POST status.

commit faad9648cf8003c731ab1518550c7d3c67c21a1d
Author: Alex Jia <ajia>
Date:   Wed Feb 8 13:50:06 2012 +0800

    virsh: Plug memory leak on cmdDesc

    Forgot to free the domain object, this will intruduce resource leaks including
memory leak and FD leaks.

    * tools/virsh.c(cmdDesc): fix memory leak.

    * How to reproduce?
    % virsh desc <domain> 
    No description for domain: <domain>
    error: Failed to disconnect from the hypervisor, 1 leaked reference(s)

Comment 3 Dave Allan 2012-02-08 14:36:30 UTC

Awesome, thanks Alex.

Comment 6 xhu 2012-02-15 06:51:55 UTC

Reproduce it with libvirt-0.9.10-0rc1.el6.x86_64.
Verify it with libvirt-0.9.10-1.el6 and it passed.
The steps are as follows:
1 
# virsh desc vr-rhel6-x86_64-kvm
No description for domain: vr-rhel6-x86_64-kvm

2 
# valgrind -v --leak-check=full virsh desc vr-rhel6-x86_64-kvm
...
==10520== LEAK SUMMARY:
==10520==    definitely lost: 0 bytes in 0 blocks
==10520==    indirectly lost: 0 bytes in 0 blocks
==10520==      possibly lost: 0 bytes in 0 blocks
==10520==    still reachable: 127,140 bytes in 1,344 blocks
==10520==         suppressed: 0 bytes in 0 blocks
...

Comment 8 errata-xmlrpc 2012-06-20 06:48:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html