Bug 788338 – Resource leaks on virsh desc command

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 788338 - Resource leaks on virsh desc command

Summary:	Resource leaks on virsh desc command

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libvirt (Show other bugs)
Sub Component:
Version:	6.3
Hardware:	x86_64 Linux

Priority	high Severity high
Target Milestone:	rc
Target Release:	---
Assigned To:	Alex Jia
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-08 00:02 EST by Alex Jia
Modified:	2012-06-20 02:48 EDT (History)
CC List:	7 users (show)

See Also:
Fixed In Version:	libvirt-0.9.10-1.el6
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-06-20 02:48:01 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2012:0748	normal	SHIPPED_LIVE	Low: libvirt security, bug fix, and enhancement update	2012-06-19 15:31:38 EDT

Groups: None (edit)

Description Alex Jia 2012-02-08 00:02:06 EST

Description of problem:
virsh desc has 1 leaked reference.

Version-Release number of selected component (if applicable):
# rpm -q libvirt
libvirt-0.9.10-0rc1.el6.x86_64


How reproducible:
always

Steps to Reproduce:
1. virsh desc <domain>
2.
3.
  
Actual results:
# virsh desc foo
No description for domain: foo
error: Failed to disconnect from the hypervisor, 1 leaked reference(s)


Expected results:
avoid resource leak.

Additional info:
my guest 'foo' originally hasn't any description.

Comment 1 Alex Jia 2012-02-08 00:58:48 EST

The patch has been sent to upstream and wait for review:
https://www.redhat.com/archives/libvir-list/2012-February/msg00409.html

Comment 2 Alex Jia 2012-02-08 04:17:19 EST

The patch has been ACKed and pushed, so move bug to POST status.

commit faad9648cf8003c731ab1518550c7d3c67c21a1d
Author: Alex Jia <ajia@redhat.com>
Date:   Wed Feb 8 13:50:06 2012 +0800

    virsh: Plug memory leak on cmdDesc

    Forgot to free the domain object, this will intruduce resource leaks including
memory leak and FD leaks.

    * tools/virsh.c(cmdDesc): fix memory leak.

    * How to reproduce?
    % virsh desc <domain> 
    No description for domain: <domain>
    error: Failed to disconnect from the hypervisor, 1 leaked reference(s)

Comment 3 Dave Allan 2012-02-08 09:36:30 EST

Awesome, thanks Alex.

Comment 6 xhu 2012-02-15 01:51:55 EST

Reproduce it with libvirt-0.9.10-0rc1.el6.x86_64.
Verify it with libvirt-0.9.10-1.el6 and it passed.
The steps are as follows:
1 
# virsh desc vr-rhel6-x86_64-kvm
No description for domain: vr-rhel6-x86_64-kvm

2 
# valgrind -v --leak-check=full virsh desc vr-rhel6-x86_64-kvm
...
==10520== LEAK SUMMARY:
==10520==    definitely lost: 0 bytes in 0 blocks
==10520==    indirectly lost: 0 bytes in 0 blocks
==10520==      possibly lost: 0 bytes in 0 blocks
==10520==    still reachable: 127,140 bytes in 1,344 blocks
==10520==         suppressed: 0 bytes in 0 blocks
...

Comment 8 errata-xmlrpc 2012-06-20 02:48:01 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html

Note You need to log in before you can comment on or make changes to this bug.