Bug 789251

[+]MUST: rpmlint must be run on every package. The output should be posted in the review.
jmeters.src: W: spelling-error Summary(en_US) Multichannel -> Channelization
The value of this tag appears to be misspelled. Please double-check.

jmeters.src: W: spelling-error %description -l en_US multichannel -> channelization
The value of this tag appears to be misspelled. Please double-check.

jmeters.src: W: spelling-error %description -l en_US meterbridge -> meter bridge, meter-bridge, Bridgette
The value of this tag appears to be misspelled. Please double-check.

jmeters.src: W: spelling-error %description -l en_US pixmaps -> pix maps, pix-maps, bitmaps
The value of this tag appears to be misspelled. Please double-check.

jmeters.x86_64: W: spelling-error Summary(en_US) Multichannel -> Channelization
The value of this tag appears to be misspelled. Please double-check.

jmeters.x86_64: W: spelling-error %description -l en_US multichannel -> channelization
The value of this tag appears to be misspelled. Please double-check.

jmeters.x86_64: W: spelling-error %description -l en_US meterbridge -> meter bridge, meter-bridge, Bridgette
The value of this tag appears to be misspelled. Please double-check.

jmeters.x86_64: W: spelling-error %description -l en_US pixmaps -> pix maps, pix-maps, bitmaps
The value of this tag appears to be misspelled. Please double-check.

jmeters.x86_64: E: incorrect-fsf-address /usr/share/doc/jmeters-0.2.0/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters.x86_64: W: no-manual-page-for-binary jmeters
Each executable in standard binary directories should have a man page.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/jclient.cc
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/meterwin.cc
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/jclient.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/mainwin.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/mainwin.cc
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/global.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/meterwin.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/jmeters.cc
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/styles.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jmeters-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jmeters-0.2.0/source/styles.cc
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

3 packages and 1 specfiles checked; 11 errors, 9 warnings.

Please contact upstream to correct the COPYING file and headers in the source code.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - OK, please query upstream to correct FSF address.
        changelogs - OK, the latest changelog entry is not correct. Your name is not mentioned.
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK , no api documentation

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
COPYING file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.

md5sum jmeters-0.2.0-2.fc16.src/jmeters-0.2.0.tar.bz2 
cd69c517698762c8139bd8a789098f7e  jmeters-0.2.0-2.fc16.src/jmeters-0.2.0.tar.bz2

md5sum jmeters-0.2.0.tar.bz2 
cd69c517698762c8139bd8a789098f7e  jmeters-0.2.0.tar.bz2

[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[NA]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[NA]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section
[+]MUST: Packages must not own files or directories already owned by other packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[-]SHOULD : All files should mention the license at the beginning.
Two files do not have such information (mkimage.cc and mkimage.h)
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

APPROVED.

Overall comments (not blockers):
Please query upstream to correct FSF address.
The latest changelog entry is not correct. Your name is not mentioned.
Two files do not have license information mentioned. Please query upstream to include it.

Thanks for the review! Upstream has been notified of the invalid addresses and the changelog will be corrected before commit. 

New Package SCM Request
=======================
Package Name: jmeters
Short Description: Multichannel audio level meter
Owners: bsjones
Branches: f15 f16 f17
InitialCC:

Git done (by process-git-requests).

jmeters-0.2.0-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/jmeters-0.2.0-3.fc16

jmeters-0.2.0-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/jmeters-0.2.0-3.fc17

jmeters-0.2.0-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/jmeters-0.2.0-3.fc15

Package jmeters-0.2.0-3.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing jmeters-0.2.0-3.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-2605/jmeters-0.2.0-3.fc17
then log in and leave karma (feedback).

jmeters-0.2.0-3.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

jmeters-0.2.0-3.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

jmeters-0.2.0-3.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.