Bug 789255

http://bsjones.fedorapeople.org/ebumeter-0.1.0-2.fc16.src.rpm

License is GPLv2+, according to the code.

As you ship the desktop file as a separate source, I suggest not to modify it in the specfile.

SRPM: http://bsjones.fedorapeople.org/ebumeter-0.1.0-3.fc16.src.rpm
SPEC: http://bsjones.fedorapeople.org/ebumeter.spec

Modified as suggested

Your desktop file does not specify an icon. I therefore assume, you're not installing one -- specifically not into the hicolor directory.

Therefore the scriptlets are not necessary.

SRPM: http://bsjones.fedorapeople.org/ebumeter-0.1.0-4.fc16.src.rpm
SPEC: http://bsjones.fedorapeople.org/ebumeter.spec

I have an icon from upstream, installed in pixmaps instead so scriptlets have been removed

I recommend to put Name before Summary.

Please preserve the icon's timestamp with something like "install -p -m644 ...".

The FSF postal address SHOULD be corrected and upstream should be informed.

Other than that, everything looks fine. I'll take the review.

Thanks for the help.

Updated here:

SRPM: http://bsjones.fedorapeople.org/ebumeter-0.1.0-5.fc16.src.rpm
SPEC: http://bsjones.fedorapeople.org/ebumeter.spec

It seems to me, you don't have to BR:

fftw-devel
clalsadrv-devel
alsa-lib-devel
libX11-devel

Updated here:

SRPM: http://bsjones.fedorapeople.org/ebumeter-0.1.0-6.fc16.src.rpm
SPEC: http://bsjones.fedorapeople.org/ebumeter.spec

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== C/C++ ====
[-]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.


==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[-]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.

rpmlint ebumeter-0.1.0-6.fc18.i686.rpm

ebumeter.i686: W: no-manual-page-for-binary ebur128
ebumeter.i686: W: no-manual-page-for-binary ebumeter
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint ebumeter-0.1.0-6.fc18.src.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint ebumeter-debuginfo-0.1.0-4.fc18.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

All the warnings can be ignored.

[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/makerpm/789255/ebumeter-0.1.0.tar.bz2 :
  MD5SUM this package     : b1fd8fec7098a7e8937d999f07b984ec
  MD5SUM upstream package : b1fd8fec7098a7e8937d999f07b984ec

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Final remarks:

Please fix those warnings:

[makerpm@lenovo-muw SOURCES]$ desktop-file-validate ebumeter.desktop
ebumeter.desktop: error: value "Application;AudioVideo;Audio;X-Jack;X-Audio_Tools" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
ebumeter.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated

As soon as that is solved, I'll approve the package.

Please inform upstream about the wrong FSF address, if you haven't already.

Cosmetics:

Please remove the space in front of the exclamation mark in the description and break the line before "presentation", so the text is less ragged. Also delete the empty line at the beginnning of the file.

Generated by fedora-review 0.1.2
External plugins:

Done! Thanks for the review 

SRPM: http://bsjones.fedorapeople.org/ebumeter-0.1.0-7.fc16.src.rpm
SPEC: http://bsjones.fedorapeople.org/ebumeter.spec

== APPROVED ==

Thank you for the review

New Package SCM Request
=======================
Package Name: ebumeter
Short Description: Loudness measurement according to EBU-R128
Owners: bsjones
Branches: f15 f16 f17
InitialCC:

Git done (by process-git-requests).

ebumeter-0.1.0-7.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/ebumeter-0.1.0-7.fc16

ebumeter-0.1.0-7.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ebumeter-0.1.0-7.fc15

ebumeter-0.1.0-7.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/ebumeter-0.1.0-7.fc17

ebumeter-0.1.0-7.fc17 has been pushed to the Fedora 17 testing repository.

ebumeter-0.1.0-7.fc16 has been pushed to the Fedora 16 stable repository.

ebumeter-0.1.0-7.fc15 has been pushed to the Fedora 15 stable repository.

ebumeter-0.1.0-7.fc17 has been pushed to the Fedora 17 stable repository.