Bug 796183
| Summary: | Review Request: python-nitrate - Python API for the Nitrate test case management system | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šplíchal <psplicha> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, notting, ohudlick, package-review |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-nitrate-0.8-0.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-28 11:04:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petr Šplíchal
2012-02-22 12:50:26 UTC
- URL should probably point to [1], which contains some information about the project, not the directory with source files/tars/etc...
- You should use "install -p" to preserve timestamps, see [2].
- You cannot own %{python_sitelib} - that would imply that you own the whole directory with any files _even from other packages_ (and after uninstallation of your package, it would remove this directory with everything inside it). Rather than that, use %{python_sitelib}/*, which will cause your package to own all the files that are under %{buildroot}%{python_sitelib}.
- Otherwise the package looks good and works, so when you fix these problems, it can be approved.
[1] http://psss.fedorapeople.org/python-nitrate/python-nitrate.html
[2] https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
(In reply to comment #2) > - URL should probably point to [1], which contains some information about the > project, not the directory with source files/tars/etc... Agree, I've updated the link. > - You should use "install -p" to preserve timestamps, see [2]. Fixed. > - You cannot own %{python_sitelib} - that would imply that you own the whole > directory with any files _even from other packages_ (and after uninstallation > of your package, it would remove this directory with everything inside it). > Rather than that, use %{python_sitelib}/*, which will cause your package to own > all the files that are under %{buildroot}%{python_sitelib}. Oh, I had that before but then "simplified" it in the wrong direction. This is now fixed as well. > - Otherwise the package looks good and works, so when you fix these problems, > it can be approved. Thanks for the review! New spec file and source rpm are ready: http://psss.fedorapeople.org/python-nitrate/python-nitrate.spec http://psss.fedorapeople.org/python-nitrate/python-nitrate-0.7-2.el6.src.rpm Everything is ok now, package is APPROVED. New Package SCM Request ======================= Package Name: python-nitrate Short Description: Python API for the Nitrate test case management system Owners: psss Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). python-nitrate-0.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-nitrate-0.7-2.el6 python-nitrate-0.7-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-nitrate-0.7-2.fc16 python-nitrate-0.7-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-nitrate-0.7-2.fc17 python-nitrate-0.7-2.fc17 has been pushed to the Fedora 17 testing repository. python-nitrate-0.7-2.fc17 has been pushed to the Fedora 17 stable repository. python-nitrate-0.8-0.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-nitrate-0.8-0.el6 python-nitrate-0.8-0.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-nitrate-0.8-0.fc16 python-nitrate-0.8-0.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. python-nitrate-0.8-0.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: python-nitrate New Branches: epel7 Owners: psss Git done (by process-git-requests). |