Bug 796183 - Review Request: python-nitrate - Python API for the Nitrate test case management system
Summary: Review Request: python-nitrate - Python API for the Nitrate test case managem...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bohuslav "Slavek" Kabrda
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-22 12:50 UTC by Petr Šplíchal
Modified: 2016-06-01 01:42 UTC (History)
4 users (show)

Fixed In Version: python-nitrate-0.8-0.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-28 11:04:31 UTC
Type: ---
bkabrda: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šplíchal 2012-02-22 12:50:26 UTC
Spec URL: http://psss.fedorapeople.org/python-nitrate/python-nitrate.spec
SRPM URL: http://psss.fedorapeople.org/python-nitrate/python-nitrate-0.7-1.el6.src.rpm

Description:
python-nitrate is a Python interface to the Nitrate test case
management system. The package consists of a high-level Python
module (provides natural object interface), a low-level driver
(allows to directly access Nitrate's XMLRPC API) and a command
line interpreter (useful for fast debugging and experimenting).

Links:
Git: http://fedorapeople.org/gitweb?p=psss/public_git/python-nitrate
Doc: http://psss.fedorapeople.org/python-nitrate/python-nitrate.html

Note:
This is my first package so I will need a sponsor. Thanks.

Comment 2 Bohuslav "Slavek" Kabrda 2012-02-22 13:58:39 UTC
- URL should probably point to [1], which contains some information about the project, not the directory with source files/tars/etc...
- You should use "install -p" to preserve timestamps, see [2].
- You cannot own %{python_sitelib} - that would imply that you own the whole directory with any files _even from other packages_ (and after uninstallation of your package, it would remove this directory with everything inside it). Rather than that, use %{python_sitelib}/*, which will cause your package to own all the files that are under %{buildroot}%{python_sitelib}.
- Otherwise the package looks good and works, so when you fix these problems, it can be approved.


[1] http://psss.fedorapeople.org/python-nitrate/python-nitrate.html
[2] https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

Comment 3 Petr Šplíchal 2012-02-22 14:35:33 UTC
(In reply to comment #2)
> - URL should probably point to [1], which contains some information about the
> project, not the directory with source files/tars/etc...

Agree, I've updated the link.

> - You should use "install -p" to preserve timestamps, see [2].

Fixed.

> - You cannot own %{python_sitelib} - that would imply that you own the whole
> directory with any files _even from other packages_ (and after uninstallation
> of your package, it would remove this directory with everything inside it).
> Rather than that, use %{python_sitelib}/*, which will cause your package to own
> all the files that are under %{buildroot}%{python_sitelib}.

Oh, I had that before but then "simplified" it in the wrong
direction. This is now fixed as well.

> - Otherwise the package looks good and works, so when you fix these problems,
> it can be approved.

Thanks for the review! New spec file and source rpm are ready:

http://psss.fedorapeople.org/python-nitrate/python-nitrate.spec
http://psss.fedorapeople.org/python-nitrate/python-nitrate-0.7-2.el6.src.rpm

Comment 4 Bohuslav "Slavek" Kabrda 2012-02-22 14:43:57 UTC
Everything is ok now, package is APPROVED.

Comment 5 Petr Šplíchal 2012-02-22 15:03:45 UTC
New Package SCM Request
=======================
Package Name: python-nitrate
Short Description: Python API for the Nitrate test case management system
Owners: psss
Branches: f16 f17 el6
InitialCC:

Comment 6 Gwyn Ciesla 2012-02-22 15:14:33 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2012-02-23 10:35:19 UTC
python-nitrate-0.7-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-nitrate-0.7-2.el6

Comment 8 Fedora Update System 2012-02-23 10:39:10 UTC
python-nitrate-0.7-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-nitrate-0.7-2.fc16

Comment 9 Fedora Update System 2012-02-23 10:41:29 UTC
python-nitrate-0.7-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-nitrate-0.7-2.fc17

Comment 10 Fedora Update System 2012-02-23 22:28:05 UTC
python-nitrate-0.7-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 11 Fedora Update System 2012-02-28 11:04:31 UTC
python-nitrate-0.7-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 12 Fedora Update System 2012-02-29 15:40:39 UTC
python-nitrate-0.8-0.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-nitrate-0.8-0.el6

Comment 13 Fedora Update System 2012-02-29 15:40:51 UTC
python-nitrate-0.8-0.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-nitrate-0.8-0.fc16

Comment 14 Fedora Update System 2012-03-15 02:26:37 UTC
python-nitrate-0.8-0.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2012-03-15 19:53:55 UTC
python-nitrate-0.8-0.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Petr Šplíchal 2014-08-08 16:16:33 UTC
Package Change Request
======================
Package Name: python-nitrate
New Branches: epel7
Owners: psss

Comment 17 Gwyn Ciesla 2014-08-08 16:21:13 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.