| Summary: | Review Request: yawn - Web-based CIM/WBEM browser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vitezslav Crhonek <vcrhonek> |
| Component: | Package Review | Assignee: | Jan Safranek <jsafrane> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jsafrane, miminar, notting, package-review |
| Target Milestone: | --- | Flags: | jsafrane:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-29 10:02:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Vitezslav Crhonek
2012-02-23 14:18:27 UTC
rpmlint output is OK, only one warning in compiled package:
rpmlint yawn-1.0-2.fc18.noarch.rpm
yawn.noarch: W: no-documentation
Problems found:
- BuildRoot: tag is obsolete
- Source0: must point to upstream source file, i.e. probably http://pywbem.svn.sourceforge.net/viewvc/pywbem/yawn/trunk/yawn.py?revision=561
- version does not match! You use svn checkout and thus you should follow https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages
- the package should own all directories it creates, i.e. also /var/www/yawn
Things to consider:
- use systemctl instead of /sbin/service to restart httpd
Updated version: http://vcrhonek.fedorapeople.org/yawn/yawn.spec http://vcrhonek.fedorapeople.org/yawn/yawn-0-0.1.20120227svn561.fc16.src.rpm (In reply to comment #1) > rpmlint output is OK, only one warning in compiled package: > rpmlint yawn-1.0-2.fc18.noarch.rpm > yawn.noarch: W: no-documentation > > Problems found: > - BuildRoot: tag is obsolete Removed. > - Source0: must point to upstream source file, i.e. probably > http://pywbem.svn.sourceforge.net/viewvc/pywbem/yawn/trunk/yawn.py?revision=561 Fixed, I followed this guideline: https://fedoraproject.org/wiki/Packaging:SourceURL > - version does not match! You use svn checkout and thus you should follow > https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages Fixed (hopefully:)). > - the package should own all directories it creates, i.e. also /var/www/yawn Fixed. > > Things to consider: > - use systemctl instead of /sbin/service to restart httpd Done. (In reply to comment #2) > > - Source0: must point to upstream source file, i.e. probably > > http://pywbem.svn.sourceforge.net/viewvc/pywbem/yawn/trunk/yawn.py?revision=561 > > Fixed, I followed this guideline: > https://fedoraproject.org/wiki/Packaging:SourceURL https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control Now the package is perfect and I approve the package. rpmbuild just complains: Processing files: yawn-0-0.1.20120227svn561.fc16.noarch warning: File listed twice: /var/www/yawn/index.py warning: File listed twice: /var/www/yawn/index.pyc warning: File listed twice: /var/www/yawn/index.pyo Which does not do any harm (the package does not have any subpackages) and can be fixed later. New Package SCM Request ======================= Package Name: yawn Short Description: Web-based CIM/WBEM browser Owners: vcrhonek Branches: f16 f17 InitialCC: Git done (by process-git-requests). Package Change Request ====================== Package Name: yawn New Branches: el6 el7 Owners: miminar jsafrane vcrhonek InitialCC: Git done (by process-git-requests). |