Bug 796703 - Review Request: yawn - Web-based CIM/WBEM browser
Summary: Review Request: yawn - Web-based CIM/WBEM browser
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Safranek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-23 14:18 UTC by Vitezslav Crhonek
Modified: 2014-02-21 14:28 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-29 10:02:33 UTC
Type: ---
jsafrane: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Vitezslav Crhonek 2012-02-23 14:18:27 UTC
Spec URL: http://vcrhonek.fedorapeople.org/yawn/yawn.spec
SRPM URL: http://vcrhonek.fedorapeople.org/yawn/yawn-1.0-2.fc16.src.rpm
Description: Web-based CIM/WBEM browser

Comment 1 Jan Safranek 2012-02-24 12:18:33 UTC
rpmlint output is OK, only one warning in compiled package:
    rpmlint yawn-1.0-2.fc18.noarch.rpm
    yawn.noarch: W: no-documentation

Problems found:
- BuildRoot: tag is obsolete
- Source0: must point to upstream source file, i.e. probably http://pywbem.svn.sourceforge.net/viewvc/pywbem/yawn/trunk/yawn.py?revision=561 
- version does not match! You use svn checkout and thus you should follow https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages
- the package should own all directories it creates, i.e. also /var/www/yawn

Things to consider:
- use systemctl instead of /sbin/service to restart httpd

Comment 2 Vitezslav Crhonek 2012-02-27 13:34:21 UTC
Updated version:
http://vcrhonek.fedorapeople.org/yawn/yawn.spec
http://vcrhonek.fedorapeople.org/yawn/yawn-0-0.1.20120227svn561.fc16.src.rpm


(In reply to comment #1)
> rpmlint output is OK, only one warning in compiled package:
>     rpmlint yawn-1.0-2.fc18.noarch.rpm
>     yawn.noarch: W: no-documentation
> 
> Problems found:
> - BuildRoot: tag is obsolete

Removed.

> - Source0: must point to upstream source file, i.e. probably
> http://pywbem.svn.sourceforge.net/viewvc/pywbem/yawn/trunk/yawn.py?revision=561 

Fixed, I followed this guideline:
https://fedoraproject.org/wiki/Packaging:SourceURL

> - version does not match! You use svn checkout and thus you should follow
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages

Fixed (hopefully:)).

> - the package should own all directories it creates, i.e. also /var/www/yawn

Fixed.

> 
> Things to consider:
> - use systemctl instead of /sbin/service to restart httpd

Done.

Comment 3 Vitezslav Crhonek 2012-02-27 13:35:58 UTC
(In reply to comment #2)

> > - Source0: must point to upstream source file, i.e. probably
> > http://pywbem.svn.sourceforge.net/viewvc/pywbem/yawn/trunk/yawn.py?revision=561 
> 
> Fixed, I followed this guideline:
> https://fedoraproject.org/wiki/Packaging:SourceURL

https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

Comment 4 Jan Safranek 2012-02-28 08:42:43 UTC
Now the package is perfect and I approve the package.

rpmbuild just complains:
Processing files: yawn-0-0.1.20120227svn561.fc16.noarch
warning: File listed twice: /var/www/yawn/index.py
warning: File listed twice: /var/www/yawn/index.pyc
warning: File listed twice: /var/www/yawn/index.pyo

Which does not do any harm (the package does not have any subpackages) and can be fixed later.

Comment 5 Vitezslav Crhonek 2012-02-28 10:57:40 UTC
New Package SCM Request
=======================
Package Name: yawn
Short Description: Web-based CIM/WBEM browser
Owners: vcrhonek
Branches: f16 f17
InitialCC:

Comment 6 Gwyn Ciesla 2012-02-28 13:17:03 UTC
Git done (by process-git-requests).

Comment 7 Michal Minar 2014-02-21 13:48:53 UTC
Package Change Request
======================
Package Name: yawn
New Branches: el6 el7
Owners: miminar jsafrane vcrhonek
InitialCC:

Comment 8 Gwyn Ciesla 2014-02-21 14:28:05 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.