| Summary: | Review Request: trac-sumfields-plugin - Sums specified fields in custom queries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-31 02:56:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Tom "spot" Callaway
2012-02-27 15:26:21 UTC
Will review. Look for a review in a bit here. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 3e33f74f12819f4864f4cb051fd07b9f trac-sumfields-plugin-1.0.1.svn10482.tar.gz a1b51aaa80cf173416808995d9b569a5 trac-sumfields-plugin-1.0.1.svn10482.tar.gz.orig (difference is timestamps and other svn stuff, content is the same) OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Might ask upstream to include a copy of the License. (not a blocker). 2. rpmlint says: trac-sumfields-plugin.noarch: W: no-documentation trac-sumfields-plugin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/sumfields/templates/sumfields.html trac-sumfields-plugin.src: W: invalid-url Source0: trac-sumfields-plugin-1.0.1.svn10482.tar.gz Possibly fix the perms on the html file to quiet rpmlint? Others can be ignored. I see no other blockers/issues here, so this package is APPROVED. New Package SCM Request ======================= Package Name: trac-sumfields-plugin Short Description: Sums specified fields in custom queries Owners: spot Branches: f16 f17 el5 el6 InitialCC: Git done (by process-git-requests). trac-sumfields-plugin-1.0.1-1.20120227svn10482.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.el6 trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc16 trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17 trac-sumfields-plugin-1.0.1-1.20120227svn10482.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.el5 Package trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-4194/trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17 then log in and leave karma (feedback). trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. trac-sumfields-plugin-1.0.1-1.20120227svn10482.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. trac-sumfields-plugin-1.0.1-1.20120227svn10482.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |