Bug 797945 - Review Request: trac-sumfields-plugin - Sums specified fields in custom queries
Summary: Review Request: trac-sumfields-plugin - Sums specified fields in custom queries
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-27 15:26 UTC by Tom "spot" Callaway
Modified: 2012-04-12 02:39 UTC (History)
2 users (show)

Fixed In Version: trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-31 02:56:18 UTC
Type: ---
kevin: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2012-02-27 15:26:21 UTC
Spec URL: http://spot.fedorapeople.org/trac-sumfields-plugin.spec
SRPM URL: http://spot.fedorapeople.org/trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17.src.rpm
Description: 
A trac plugin that allows you to sum fields in Trac custom queries.

Comment 1 Kevin Fenzi 2012-02-27 17:29:51 UTC
Will review. Look for a review in a bit here.

Comment 2 Kevin Fenzi 2012-02-27 17:38:51 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
3e33f74f12819f4864f4cb051fd07b9f  trac-sumfields-plugin-1.0.1.svn10482.tar.gz
a1b51aaa80cf173416808995d9b569a5  trac-sumfields-plugin-1.0.1.svn10482.tar.gz.orig
(difference is timestamps and other svn stuff, content is the same)

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin

Issues: 

1. Might ask upstream to include a copy of the License. (not a blocker). 

2. rpmlint says: 

trac-sumfields-plugin.noarch: W: no-documentation
trac-sumfields-plugin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/sumfields/templates/sumfields.html
trac-sumfields-plugin.src: W: invalid-url Source0: trac-sumfields-plugin-1.0.1.svn10482.tar.gz

Possibly fix the perms on the html file to quiet rpmlint?
Others can be ignored. 

I see no other blockers/issues here, so this package is APPROVED.

Comment 3 Tom "spot" Callaway 2012-03-16 20:05:49 UTC
New Package SCM Request
=======================
Package Name: trac-sumfields-plugin
Short Description: Sums specified fields in custom queries
Owners: spot
Branches: f16 f17 el5 el6
InitialCC:

Comment 4 Gwyn Ciesla 2012-03-17 02:27:45 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2012-03-19 20:16:48 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.el6

Comment 6 Fedora Update System 2012-03-19 20:16:56 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc16

Comment 7 Fedora Update System 2012-03-19 20:17:05 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17

Comment 8 Fedora Update System 2012-03-19 20:17:35 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/trac-sumfields-plugin-1.0.1-1.20120227svn10482.el5

Comment 9 Fedora Update System 2012-03-20 06:03:28 UTC
Package trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-4194/trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2012-03-31 02:56:18 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2012-04-05 03:04:02 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2012-04-05 03:06:49 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2012-04-12 02:39:03 UTC
trac-sumfields-plugin-1.0.1-1.20120227svn10482.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.