Bug 798715
| Summary: | Review Request: luminance-hdr - A graphical tool for creating and tone-mapping HDR images | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Franco Comida <francocomida> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | d.bz-redhat, notting, package-review, philip.frampton, quantum.analyst, rdieter, rom1dep |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-04-19 12:21:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Franco Comida
2012-02-29 16:10:42 UTC
Luminance HDR is the successor of qtpfsgui already present on Fedora. It adds much more stability and functionalities This is my first package and I am seeking a sponsor, also the package depends on LibRaw-0.14 that is not present on Fedora. *** Bug 798703 has been marked as a duplicate of this bug. *** *** Bug 798714 has been marked as a duplicate of this bug. *** The LibRaw-0.14 package is already on rawhide. I successfully built it with koji on f16. I am also in contact with the old maintainer who is willing to help with the review *** Bug 666500 has been marked as a duplicate of this bug. *** *** Bug 699703 has been marked as a duplicate of this bug. *** rpmlint: ok $ rpmlint luminance-hdr luminance-hdr.x86_64: I: enchant-dictionary-not-found en_US luminance-hdr.x86_64: W: no-manual-page-for-binary luminance-hdr 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Naming: not ok 1. since this is successor of qtpfsgui and replaces it, MUST follow http://fedoraproject.org/wiki/Packaging/Guidelines#Renaming.2FReplacing_Existing_Packages and contain (something like): Obsoletes: qtpfsgui < 2.2.0 Provides: qtpfsgui = %{version}-%{release} for upgrade path 2. Sources: MUST. md5sum does not match. in src.rpm: bd2d3782257cf502517e79852fff40be luminance-hdr-2.2.0.tar.bz2 fetched from sourceforge: 15caab0747cc5d5f1a3a496752b733d4 luminance-hdr-2.2.0.tar.bz2 3. scriptlets. MUST update icon scriptlets to match, http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 4. .desktop file. MUST not use --vendor=fedora, see http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Licensing: Ok. got mostly GPLv2+, with some BSD, LGPLv2+. combined work is GPLv2+ Address items 1-4, and we're looking good. I addressed all the points. Should be ok now. Make sure to update changelog and bump release next time whenever doing changes. item 2. Source checksums. Strange, your srpm tarball is the same, but sourceforge's upstream one seems to have been changed to match. ? I would've expected the other way around. Can you explain? I am upstream so I changed the tarball on SourceForge because the old one didn't include the root directory. Sorry for the missing updated changelog and release, I tought it wasn't needed for a package not yet in the distribution. I guess I missed mentioning the need to add another scriptlet for Mimetype support, http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database and likewise, if registerring new mimetypes, http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo but I won't consider that a blocker. just look into it. Otherwise, I'm happy with the changes done, and looks good. APPROVED. please post your fas ID, from http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account and I'll sponsor you. My fas ID is fcomida I will update the spec file with the scriplets for mime type support as soon as the new version 2.2.1 is released. sponsored, welcome! can move on to http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner After some testing, the package as provided on sourceforge for fedora 16 x86_64 is in a good shape, app is stable, menu entries are ok. Updated at version 2.2.1 Spec URL: http://sourceforge.net/projects/qtpfsgui/files/luminance/2.2.1/luminance-hdr.spec/download SRPM URL: http://sourceforge.net/projects/qtpfsgui/files/luminance/2.2.1/luminance-hdr-2.2.1-1.fc16.src.rpm/download rpmlint -v luminance-hdr-2.2.1-1.fc16.src.rpm luminance-hdr.src: I: checking luminance-hdr.src: I: checking-url http://qtpfsgui.sourceforge.net/ (timeout 10 seconds) luminance-hdr.src: I: checking-url http://downloads.sourceforge.net/qtpfsgui/luminance-hdr-2.2.1.tar.bz2 (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -v luminance-hdr.spec luminance-hdr.spec: I: checking-url http://downloads.sourceforge.net/qtpfsgui/luminance-hdr-2.2.1.tar.bz2 (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. New Package SCM Request ======================= Package Name: luminance-hdr Short Description: A graphical tool for creating and tone-mapping HDR images Owners: fcomida Branches: f17 InitialCC: rdieter Summary and SCM request package name don't match, please correct. Thanks! New Package SCM Request ======================= Package Name: Luminance HDR Short Description: A graphical tool for creating and tone-mapping HDR images Owners: fcomida Branches: f17 InitialCC: rdieter No, you want to use luminance-hdr in both places, not "Luminance HDR". I'll fix summary, just redo comment #18 New Package SCM Request ======================= Package Name: luminance-hdr Short Description: A graphical tool for creating and tone-mapping HDR images Owners: fcomida Branches: f17 InitialCC: rdieter Git done (by process-git-requests). $ koji latest-pkg f18 luminance-hdr Build Tag Built by ---------------------------------------- -------------------- ---------------- luminance-hdr-2.2.1-3.fc18 f18 sharkcz looks like a winner, closing. |