Bug 79933
Summary: | Gnibbles exits unexpectedly trying to load level 000 | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] Red Hat Linux | Reporter: | C Duvall <caduvall> | ||||
Component: | gnome-games | Assignee: | Havoc Pennington <hp> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Jay Turner <jturner> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 7.3 | CC: | srevivo | ||||
Target Milestone: | --- | Keywords: | MoveUpstream | ||||
Target Release: | --- | ||||||
Hardware: | i686 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2002-12-19 15:55:36 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
C Duvall
2002-12-18 03:40:13 UTC
Hmm, is this an excuse to spend an entire day playing gnibbles? ;-) Created attachment 88794 [details]
Test patch to get rid of level 000
This patch is untested as I haven't figured much out about rpm yet, but it
seems to be the only place where current_level could be set to 0.
- tmp = rand () % MAXLEVEL; + tmp = rand () % MAXLEVEL + 1; This should be + tmp = rand () % (MAXLEVEL - 1) + 1; Otherwise you remove 0, and add MAXLEVEL MAXLEVEL is defined as 26 in the sources I have, and there is a level for it. Other places in the source it does rand() % MAXLEVEL + 1, validly. It looks like valid levels are 1-MAXLEVEL, inclusive. Looking further, this bug seems to be a dup of bug 52900 at bugzilla.gnome.org. Same trivial patch was submitted as fix by someone else, seems to be fixed now upstream. Thanks for looking into this. We should have the fix in the next release, then. |