Bug 799673

Created attachment 567372 [details]
proposed patch

PS I can also build/commit if necessary. Please let me know.

Tested on F16 (don't have a Fedora rawhide desktop).

Changing %F to %U is also necessary. Using %f nothing happens. %U is the same var used by trasmission-gtk and brings you straight to the "add" menu.

I am re-assigning the current active maintainer.

The issue is still present in all versions of transmission (rawhide/f18/17/16).

would be very nice to have this fixed.

The patch was done against f16, beside the spec file change, the patch is still valid.

Looks like there are two versions of transmission-qt.desktop, one of which ships with the Fedora package, and another one which is included in the transmission upstream tarball.

It would appear that the desktop file in the upstream tarball already has the x-scheme-handler/magnet mimetype.

I'll update the package to use the upstream desktop file, which should fix the mimetype issue. However, the %F -> %U change might still be needed. Can you verify this and file a ticket with upstream to change %F -> %U if needed?

Upstream issue tracker: https://trac.transmissionbt.com/

(In reply to comment #3)
> Looks like there are two versions of transmission-qt.desktop, one of which
> ships with the Fedora package, and another one which is included in the
> transmission upstream tarball.
> 
> It would appear that the desktop file in the upstream tarball already has
> the x-scheme-handler/magnet mimetype.
> 
> I'll update the package to use the upstream desktop file, which should fix
> the mimetype issue. However, the %F -> %U change might still be needed. Can
> you verify this and file a ticket with upstream to change %F -> %U if needed?
> 
> Upstream issue tracker: https://trac.transmissionbt.com/

I verified that %U is still necessary.

No sorry I won't file a bug upstream as that needs yet another account.
Also, as part of being a packager, you should already be in touch with upstream that would make things a lot easier.

There are other differences in the .desktop that might need revisit, either by fedora or upstream (or both).

[fabbione@jeeg qt]$ diff -u ../../transmission-qt.desktop transmission-qt.desktop

-Icon=transmission
+Icon=transmission-qt

^^ this one probably needs check for how the two packages ship the icon.

+X-AppInstall-Keywords=torrent
+Actions=Minimize;
+
+[Desktop Action Minimize]
+_Name=Start Transmission Minimized
+Exec=transmission-qt --minimized
+OnlyShowIn=Unity;
+

^^ I have no idea how this section work. That "OnlyShowIn" sounds very much Ubuntu specific and would have to be checked in Fedora.

Thanks
Fabio

transmission-2.76-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/transmission-2.76-1.fc18

transmission-2.76-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/transmission-2.76-1.fc17

Package transmission-2.76-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing transmission-2.76-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-1207/transmission-2.76-1.fc17
then log in and leave karma (feedback).

transmission-2.76-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

transmission-2.76-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.