Bug 799701
| Summary: | Review Request: logkeys - Linux keylogger | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | Brendan Jones <brendan.jones.it> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | brendan.jones.it, fdc, package-review |
| Target Milestone: | --- | Flags: | brendan.jones.it:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-12-17 14:37:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ankur Sinha (FranciscoD)
2012-03-04 12:58:59 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3850441 I will take this review. (In reply to comment #0) > logkeys.src: W: strange-permission logkeys-0.1.1a.tar.gz 0640L You can correct these permissions > logkeys.x86_64: W: manual-page-warning /usr/share/man/man8/logkeys.8.gz 216: You can notify upstream about this > warning: macro `..' not defined You could try this in your prep section perl -i -p -e 's/^\.\.\.\n/\n/' man/logkeys.8 and notify upstream FranciscoD, could you please update your SPEC according to Brendan's comments? Otherwise we might consider this as stalled. Hi Brendan, Francois, I seem to have somehow missed this bug. I'll update it over the weekend. Thanks for the ping. Thanks, Warm regards, Ankur Hi, * Corrected the man page error * Permissions seem okay New spec/srpm: http://ankursinha.fedorapeople.org/logkeys/logkeys.spec http://ankursinha.fedorapeople.org/logkeys/logkeys-0.1.1a-2.fc19.src.rpm Thanks, Warm regards, Ankur I'll take this(but later review coming) (In reply to Christopher Meng from comment #7) > I'll take this(but later review coming) Uhm, Christopher, can I request you to please communicate with the folks in the bug before you take over or give up the review? For instance, here there's no comment asking Brendan if he wanted to give up the bug so you can take over, and there isn't one asking if he wants to take it over now when you're giving it up. :/ Thanks, Ankur (In reply to Ankur Sinha (FranciscoD) from comment #8) > (In reply to Christopher Meng from comment #7) > > I'll take this(but later review coming) > > Uhm, > > Christopher, can I request you to please communicate with the folks in the > bug before you take over or give up the review? For instance, here there's > no comment asking Brendan if he wanted to give up the bug so you can take > over, and there isn't one asking if he wants to take it over now when you're > giving it up. :/ > > Thanks, > Ankur I think I've reseted the flag to him in July. I just removed myself from this bug as I can't see any new progress here. Thanks. Sorry I missed that it had changed back to me. Comment would be good next time. Is this still wanted? Need to change the permissions of the source tarbal and address the missing call to cgroups rpmlint. Source URL is fine logkeys.x86_64: W: spelling-error Summary(en_US) keylogger -> key logger, key-logger, flogger logkeys.x86_64: W: spelling-error %description -l en_US linux -> Linux logkeys.x86_64: W: spelling-error %description -l en_US keylogger -> key logger, key-logger, flogger logkeys.x86_64: W: spelling-error %description -l en_US keyloggers -> key loggers, key-loggers, loggers logkeys.x86_64: E: missing-call-to-setgroups /usr/bin/logkeys logkeys.x86_64: W: no-manual-page-for-binary llk logkeys.x86_64: W: no-manual-page-for-binary llkk logkeys.src: W: spelling-error Summary(en_US) keylogger -> key logger, key-logger, flogger logkeys.src: W: spelling-error %description -l en_US linux -> Linux logkeys.src: W: spelling-error %description -l en_US keylogger -> key logger, key-logger, flogger logkeys.src: W: spelling-error %description -l en_US keyloggers -> key loggers, key-loggers, loggers logkeys.src: W: strange-permission logkeys-0.1.1a.tar.gz 0640L logkeys.src: W: invalid-url Source0: http://logkeys.googlecode.com/files/logkeys-0.1.1a.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 1 errors, 12 warnings. pbrobinson's scratch build of linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a for epel7-archbootstrap and git://pkgs.fedoraproject.org/linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12089939 Dropping this - I haven't used logkeys in a long time, and I don't reckon I'll use it in the future either. Thanks for the comments. |