Bug 799896
| Summary: | Review Request: python-django-tracking - Django site visitor tracking, including basic blacklisting | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Runge <mrunge> |
| Component: | Package Review | Assignee: | Cédric OLIVIER <cedric.olivier> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cedric.olivier, notting, package-review |
| Target Milestone: | --- | Flags: | cedric.olivier:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-19 20:43:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 736776 | ||
|
Description
Matthias Runge
2012-03-05 11:17:45 UTC
Updated to match correct file source file name, some spec cleanup. Sadly, there's just a null test (just returning pass) SPEC: http://www.matthias-runge.de/fedora/python-django-tracking.spec SRPM: http://www.matthias-runge.de/fedora/python-django-tracking-0.3.7-6.fc17.src.rpm As Django, could you use your own %find_lang rather than define locale in %files section :
# Handling locale files
# This is adapted from the %%find_lang macro, which cannot be directly
# used since Django locale files are not located in %%{_datadir}
#
# The rest of the packaging guideline still apply -- do not list
# locale files by hand!
(cd $RPM_BUILD_ROOT && find . -name 'django*.mo') | %{__sed} -e 's|^.||' | %{__sed} -e \
's:\(.*/locale/\)\([^/_]\+\)\(.*\.mo$\):%lang(\2) \1\2\3:' \
>> %{name}.lang
You can find more about this "problem" here : https://bugzilla.redhat.com/show_bug.cgi?id=584866
Cédric, thank you for your hint! Fixed SPEC: http://www.matthias-runge.de/fedora/python-django-tracking.spec SRPM: http://www.matthias-runge.de/fedora/python-django-tracking-0.3.7-7.fc16.src.rpm Thanks for this update, you can find now my review :
[+] mock build OK
[+] source files match upstream
d9d3198e464d0cb89aa94d18696c4d0e
[+] package name according to the Package Naming Guidelines
[+] specfile is properly named, is cleanly written and uses macros
consistently.
[+] dist tag is present.
[+] license field matches the actual license.
[+] license is open source-compatible.
MIT
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] compiler flags are appropriate.
[+] handle locales properly
[+] package installs properly
[NA] debuginfo package looks complete.
[+] rpmlint is silent.
[+] no shared libraries are added to the regular linker search paths.
[+] owns the directories it creates.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] scriptlets are present and sane.
[+] documentation is small, so no -docs subpackage is necessary.
[NA] GUI applications must include a %{name}.desktop
[NA] contain man pages for binaries/scripts
Approved
Thank you for your review. New Package SCM Request ======================= Package Name: python-django-tracking Short Description: Django site visitor tracking, including basic blacklisting Owners: mrunge Branches: devel Ah, Cedric, you need to assign yourself to the package. Git done (by process-git-requests). Cedric, please take ownership of review BZs, thanks! imported, built and blocking request for django-tracking (in devel-branch) filed. |