Bug 801077

Review:-
+ koji scratch build for f17 ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4023812

+ rpmlint on rpms gave
fcitx-libpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5)
fcitx-libpinyin.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-libpinyin-0.1.0_dict.tar.bz2 HTTP Error 404: Not Found
fcitx-libpinyin.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha1sum)
de5b67fd10357885bc0386cb887ea09e5c48a53f  fcitx-libpinyin-0.1.0_dict.tar.bz2
de5b67fd10357885bc0386cb887ea09e5c48a53f  ../SOURCES/fcitx-libpinyin-0.1.0_dict.tar.bz2

+ Package: fcitx-libpinyin-0.1.0-1.fc17.x86_64
Provides: fcitx-libpinyin.so()(64bit)
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit) libpinyin.so.0()(64bit) libpinyin.so.0(LIBPINYIN)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH)


Suggestions:-
1) Fix the rpmlint messages. 
  a) mixed-use-of-spaces-and-tabs message can be fixed using command
     sed -i 's|\t| |g' fcitx-libpinyin.spec

2) If package is only for Fedora then no need to add
  a) %clean section (see
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
  b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
  c) remove line %defattr(-,root,root,-)

3) please don't use commands in macro that is change %{__mkdir} to "mkdir"

4) package should add Requires:fcitx

5) Use following commands in %build
%cmake ..
make VERBOSE=1 %{?_smp_mflags}

6) You need to use
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache as you are
installing icon files.

7) %install should preserve timestamp using 
   make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

8) Package does not own some of directories so change %files to

%{_datadir}/fcitx/addon/
%{_datadir}/fcitx/configdesc/
%{_datadir}/fcitx/inputmethod/

9) and yes as per rpmlint %doc is missing. Add like this to spec
%doc AUTHORS COPYING README

Ok you can drop 8) suggestion as I see fcitx-data actually owns those directories but I see bug in fcitx that it does not own %{_datadir}/%{name}/inputmethod/

Please fix first bug https://bugzilla.redhat.com/show_bug.cgi?id=816513

I have pushed the latest fcitx build to updates-testing.

And I update the fcitx-libpinyin to the latest one.

SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-libpinyin-0.1.1-1.fc16.src.rpm
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-libpinyin.spec
Koji build for F17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4026053
Koji build for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4026037

1) Are you going to push this for EPEL? If not then 
  a) %clean section (see
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
  b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
  c) remove line %defattr(-,root,root,-)

2) Missing Requires: fcitx

3) rpmlint on rpms gave
fcitx-libpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5)
fcitx-libpinyin.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-libpinyin-0.1.1_dict.tar.xz HTTP Error 404: Not Found
fcitx-libpinyin.x86_64: E: incorrect-fsf-address /usr/share/doc/fcitx-libpinyin-0.1.1/COPYING
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

==> as shown above comment1, you can fix mixed-use-of-spaces-and-tabs and for  incorrect-fsf-address, you can ask upstream to change the address. invalid-url warning can be ignored.

The spec file and SRPM have been updated.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4029319
SRPM:http://liangsuilong.fedorapeople.org/fcitx/fcitx-libpinyin-0.1.1-1.fc16.src.rpm
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-libpinyin.spec


(In reply to comment #5)
> 1) Are you going to push this for EPEL? If not then 
>   a) %clean section (see
> http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
>   b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
>   c) remove line %defattr(-,root,root,-)

i hope the package will push to EPEL. 

> 2) Missing Requires: fcitx

Fcitx has been added.

> 3) rpmlint on rpms gave
> fcitx-libpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
> line 5)
> fcitx-libpinyin.src: W: invalid-url Source0:
> http://fcitx.googlecode.com/files/fcitx-libpinyin-0.1.1_dict.tar.xz HTTP Error
> 404: Not Found
> fcitx-libpinyin.x86_64: E: incorrect-fsf-address
> /usr/share/doc/fcitx-libpinyin-0.1.1/COPYING
> 2 packages and 0 specfiles checked; 1 errors, 2 warnings.
> 
> ==> as shown above comment1, you can fix mixed-use-of-spaces-and-tabs and for 
> incorrect-fsf-address, you can ask upstream to change the address. invalid-url
> warning can be ignored.

Invalid-url warning is ignored. I can click the url and download the source tarball. And another issues are fixed.

Thanks for the update.

Package is now APPROVED.

New Package SCM Request
=======================
Package Name: fcitx-libpinyin
Short Description: Fcitx-libpinyin is a libpinyin Wrapper for Fcitx.
Owners: liangsuilong
Branches: f15 f16 f17 el6
InitialCC: i18n-team

Git done (by process-git-requests).

fcitx-libpinyin-0.1.1-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/fcitx-libpinyin-0.1.1-1.fc16

fcitx-libpinyin-0.1.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/fcitx-libpinyin-0.1.1-1.fc17

fcitx-libpinyin-0.1.1-1.fc16 has been pushed to the Fedora 16 testing repository.

fcitx-libpinyin-0.1.1-1.fc16 has been pushed to the Fedora 16 stable repository.

fcitx-libpinyin-0.1.1-1.fc17 has been pushed to the Fedora 17 stable repository.