Bug 801406

This is extremely odd. Is that to say that EAP6 is not backwards compatible with JPA 1.0?

Trying to reproduce it myself, I don't get the same error against ER3. Rather, there's a NPE when the PU is bound in JNDI from web.xml (the cause of which I cannot really understand).

Found https://issues.jboss.org/browse/JBPAPP-8397 which affects the deployment of Petclinic.

Reproduced error reported in this ticket.

a) this does not cause the deployment to fail
b) the error message is coming from Hibernate and it's spurious - JPA 1.0 deployment should be allowed 

(tracked by https://issues.jboss.org/browse/JBPAPP-8398)

Still it causes deployment exception for me:

18:36:43,234 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-4) MSC000001: Failed to start service jboss.persistenceunit."petclinic.war#petclinic": org.jboss.msc.service.StartException in service jboss.persistenceunit."petclinic.war#petclinic": Failed to start service
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1767) [jboss-msc-1.0.2.GA-redhat-1.jar:1.0.2.GA-redhat-1]
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [rt.jar:1.6.0_27]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [rt.jar:1.6.0_27]
	at java.lang.Thread.run(Thread.java:662) [rt.jar:1.6.0_27]
Caused by: javax.persistence.PersistenceException: [PersistenceUnit: petclinic] Unable to build EntityManagerFactory
	at org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:914)
	at org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:889)
	at org.hibernate.ejb.HibernatePersistence.createContainerEntityManagerFactory(HibernatePersistence.java:73)
	at org.jboss.as.jpa.service.PersistenceUnitServiceImpl.createContainerEntityManagerFactory(PersistenceUnitServiceImpl.java:162)
	at org.jboss.as.jpa.service.PersistenceUnitServiceImpl.start(PersistenceUnitServiceImpl.java:85)
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA-redhat-1.jar:1.0.2.GA-redhat-1]
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA-redhat-1.jar:1.0.2.GA-redhat-1]
	... 3 more
Caused by: org.hibernate.HibernateException: Connection cannot be null when 'hibernate.dialect' not set
	at org.hibernate.service.jdbc.dialect.internal.DialectFactoryImpl.determineDialect(DialectFactoryImpl.java:97)
	at org.hibernate.service.jdbc.dialect.internal.DialectFactoryImpl.buildDialect(DialectFactoryImpl.java:67)
	at org.hibernate.engine.jdbc.internal.JdbcServicesImpl.configure(JdbcServicesImpl.java:174)
	at org.hibernate.service.internal.StandardServiceRegistryImpl.configureService(StandardServiceRegistryImpl.java:75)
	at org.hibernate.service.internal.AbstractServiceRegistryImpl.initializeService(AbstractServiceRegistryImpl.java:159)
	at org.hibernate.service.internal.AbstractServiceRegistryImpl.getService(AbstractServiceRegistryImpl.java:131)
	at org.hibernate.cfg.SettingsFactory.buildSettings(SettingsFactory.java:71)
	at org.hibernate.cfg.Configuration.buildSettingsInternal(Configuration.java:2273)
	at org.hibernate.cfg.Configuration.buildSettings(Configuration.java:2269)
	at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1738)
	at org.hibernate.ejb.EntityManagerFactoryImpl.<init>(EntityManagerFactoryImpl.java:94)
	at org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:904)
	... 9 more

18:36:43,452 INFO  [org.jboss.as.server] (DeploymentScanner-threads - 2) JBAS015870: Deploy of deployment "petclinic.war" was rolled back with failure message {"JBAS014671: Failed services" => {"jboss.persistenceunit.\"petclinic.war#petclinic\"" => "org.jboss.msc.service.StartException in service jboss.persistenceunit.\"petclinic.war#petclinic\": Failed to start service"}}
18:36:43,487 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-2) JBAS015877: Stopped deployment petclinic.war in 35ms
18:36:43,488 INFO  [org.jboss.as.controller] (DeploymentScanner-threads - 2) JBAS014774: Service status report
JBAS014777:   Services which failed to start:      service jboss.persistenceunit."petclinic.war#petclinic": org.jboss.msc.service.StartException in service jboss.persistenceunit."petclinic.war#petclinic": Failed to start service

18:36:43,489 ERROR [org.jboss.as.server.deployment.scanner] (DeploymentScanner-threads - 1) {"JBAS014653: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-2" => {"JBAS014671: Failed services" => {"jboss.persistenceunit.\"petclinic.war#petclinic\"" => "org.jboss.msc.service.StartException in service jboss.persistenceunit.\"petclinic.war#petclinic\": Failed to start service"}}}}

Added technical note, assigning to Rebecca

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
During the import of the Petclinic project in JBDS, a default persistence.xml file with invalid contents is created under src/main/resources/META-INF. During deployment, this will supersede the correct one, to be found in src/main/environments/eap/resources/META-INF and will cause the deployment to fail. The solution in this case is to remove the src/main/resources/META-INF/persistence.xml file created during import.

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-During the import of the Petclinic project in JBDS, a default persistence.xml file with invalid contents is created under src/main/resources/META-INF. During deployment, this will supersede the correct one, to be found in src/main/environments/eap/resources/META-INF and will cause the deployment to fail. The solution in this case is to remove the src/main/resources/META-INF/persistence.xml file created during import.+During the import of the Petclinic project in JBDS, a default persistence.xml file with invalid contents is created under src/main/resources/META-INF. During deployment, this will supersede the correct one, to be found in src/main/environments/eap/resources/META-INF and will cause the deployment to fail. The workaround for this issue is to remove the src/main/resources/META-INF/persistence.xml file created during import.

Strong Liu <stliu> made a comment on jira JBPAPP-8398

https://hibernate.onjira.com/browse/HHH-6271

Strong Liu <stliu> updated the status of jira JBPAPP-8398 to Resolved

Scott Marlow <scott.marlow> made a comment on jira JBPAPP-8397

Probably easiest if I recreate locally.

Scott Marlow <scott.marlow> made a comment on jira JBPAPP-8397

I'm not sure what is causing the race yet.  From the [console output|https://gist.github.com/2002699] I can see the "Read persistence.xml" occurs first as expected (which comes from PersistenceUnitParseProcessor that runs during the PARSE deployment phase).

The NPE comes from the PersistenceRefProcessor which runs during the POST_MODULE phase.

We have our deployment phases providing the expected separation, deployment will complete the parsing of persistence.xml files, before any deployment threads try to read the result of parsing the persistence.xml.

I think its a thread safety bug in PersistenceUnitMetadataHolder.  Not sure why I didn't hit that before.

Can someone attach the petclinic.war to this jira, so I can recreate and then verify the fix.

Scott Marlow <scott.marlow> made a comment on jira JBPAPP-8397

Created a (AS7-4493) pull request to address the thread safety issue in PersistenceUnitMetadataHolder.

Scott Marlow <scott.marlow> made a comment on jira JBPAPP-8397

The thread safety fix for AS7-4493 has been merged to AS7 master.

Shelly McGowan <smcgowan> updated the status of jira JBPAPP-8397 to Resolved

Zbyněk Roubalík <zroubali> updated the status of jira JBPAPP-8398 to Closed

Zbyněk Roubalík <zroubali> made a comment on jira JBPAPP-8398

Verified on EAP 6.0.0.ER7

Created attachment 584693 [details]
Petclinic war file, WFK2 ER5, build with eap-jpa profile

Zbyněk Roubalík <zroubali> updated the status of jira JBPAPP-8397 to Closed

Zbyněk Roubalík <zroubali> made a comment on jira JBPAPP-8397

Verified on EAP 6.0.0.ER7

Misty Stanley-Jones <misty> updated the status of jira JBPAPP-8398 to Reopened

Misty Stanley-Jones <misty> made a comment on jira JBPAPP-8398

Reopening for release note.

Misty Stanley-Jones <misty> updated the status of jira JBPAPP-8398 to Resolved

Verified in WFK2 ER6 using JBDS 5.0.0.Beta3. The workaround described in Technical Notes still has to be used.

Who handles the code examples for WFK? I'd like to get this issue assigned to the correct person so it doesn't get missed for WFK 2.1.

Thanks, 

Isaac

*** Bug 824380 has been marked as a duplicate of this bug. ***

Tested with jbdevstudio-product-eap-universal-6.0.0.GA:

JBDS still adds a persistence.xml to src/main/resources/META-INF/ when importing, which continues to prevent pet-clinic from deploying. Workaround to delete the generated file (src/main/resources/META-INF/persistence.xml) works.

Release note added to WFK 2.2 RN book.

Docs stage URL: https://documentation-devel.engineering.redhat.com/docs/en-US/JBoss_Web_Framework_Kit/2.2/html-single/2.2.0_Release_Notes/index.html

Build: JBoss_Web_Framework_Kit-2.2.0_Release_Notes-2.2-en-US-0-18

Verified, release note added properly.

Updated doc text.

Migrated to JIRA.