Bug 804588 (CVE-2012-1185)

Summary:	CVE-2012-1185: ImageMagick: Incorrect fix for CVE-2012-0247
Product:	[Other] Security Response	Reporter:	Stefan Cornelius <scorneli>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	nmurray, ofourdan, pahan
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-24 21:37:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	796844, 796845
Bug Blocks:	798337

Description Stefan Cornelius 2012-03-19 10:50:33 UTC

The original fix for CVE-2012-0247 was found to be insufficient.

The original fix for CVE-2012-0247 failed to check for the possibility of an integer overflow when computing the sum of "number_bytes" and "offset". This resulted in a wrap around into a value smaller than "length", making original CVE-2012-0247 introduced "length" check still to be possible to bypass, leading to memory corruption.

Relevant upstream patches:
[1] http://trac.imagemagick.org/changeset/6998/ImageMagick/branches/ImageMagick-6.7.5/magick/profile.c
[2] http://trac.imagemagick.org/changeset/6998/ImageMagick/branches/ImageMagick-6.7.5/magick/property.c

Comment 1 Stefan Cornelius 2012-03-19 13:22:21 UTC

A CVE identifier of CVE-2012-1185 has been assigned to this issue.

Comment 2 Pavel Alexeev 2012-03-19 19:59:40 UTC

Is upstream author informed?

Comment 3 Stefan Cornelius 2012-03-19 20:16:54 UTC

(In reply to comment #2)
> Is upstream author informed?

Yes, they've been informed about the issues and published fixes (e.g. see the patches linked in the description above - comment #0).

Comment 4 Pavel Alexeev 2012-03-20 16:25:59 UTC

I speak informed about fix is not sufficient.

Comment 5 Stefan Cornelius 2012-03-20 18:04:22 UTC

Pavel,

Yes, we've informed ImageMagick upstream about the incorrect fix, so ImageMagick upstream knows about the incorrect fix. Upstream ImageMagick has completely fixed this in the ImageMagick subversion repository (3 weeks ago).

If you want to know a detailed list of the upstream ImageMagick releases including the complete fix, you should contact ImageMagick upstream.

Comment 6 Pavel Alexeev 2012-03-21 17:28:29 UTC

Do you known ImageMagick version which is not affected? I think it have worth build at least for rawhide and may be Fedora 17 too.

Comment 7 Pavel Alexeev 2012-04-11 13:29:29 UTC

Rawhide build which should fix it http://koji.fedoraproject.org/koji/taskinfo?taskID=3977291.

Comment 8 Stefan Cornelius 2012-04-24 21:37:50 UTC

Statement:

Not vulnerable. This issue did not affect the versions of ImageMagick as shipped with Red Hat Enterprise Linux 5 and 6 as they did not backport the insufficient patch for CVE-2012-0247.