Bug 807671

Summary:	Count of number of children and descendants in compatible group list view goes wrong if a member resource is disabled
Product:	[Other] RHQ Project	Reporter:	Sunil Kondkar <skondkar>
Component:	Core UI	Assignee:	Jay Shaughnessy <jshaughn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	urgent	Docs Contact:
Priority:	high
Version:	4.4	CC:	hrupp
Target Milestone:	---
Target Release:	RHQ 4.4.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-31 10:11:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	782579

Description Sunil Kondkar 2012-03-28 13:05:26 UTC

Description of problem:

Created a compatible group of resource (Ex. Cron server resource , not recursive)
In the compatible group list view (Inventory->Compatible groups), the Count of number of children is 1 and for descendants, the count is 1.

Then disabled the Cron server resource.

The compatible group list view (Inventory->Compatible groups) now displays the Count of number of children as 3 and for descendants, the count as 3.

Version-Release number of selected component (if applicable):

Build#1203 (Version: 4.4.0-SNAPSHOT Build Number: 969ed45)

How reproducible:

Always

Steps to Reproduce:
1. Created a compatible group of resource (I created for a single cron server resource)
2. Navigate to Inventory->Compatible groups and observe the count of number of children and descendants in compatible group list view.
3. Navigate to Inventory->Servers.
4. Disable the member resource. (Cron server resource)
5. Navigate to Inventory->Compatible groups and observe the count of number of children and descendants in compatible group list view.

  
Actual results:

Count of number of children and descendants in compatible group list view goes wrong if a member resource is disabled.

Expected results:

Correct count of number of children and descendants in compatible group list view.


Additional info:

Comment 1 Jay Shaughnessy 2012-03-28 21:33:18 UTC

This is a good one (meaning, a doozy), it has to do with
ResourceGroupComposite and the way it handles avail information. This will
take some work...

Comment 2 Jay Shaughnessy 2012-03-30 20:27:13 UTC

master commit daec885053b6679e4bb6a80c7c8dc86c75868a4b

The first pass at handling group avail given the latest avail changes
tried to maintain the old mechanism for determining the group avail. This
ended up not covering all of the cases. So, the double/ratio approach has
been completely scrapped and the mechanism now full incorporates disabled 
group members.  Now:
- group list views include a disabled member count and icon (note, the count
  columns are not 50% wider to accommodate).
- new group avail icons and badged group icons have been put in place for 
  disabled
- group availability is now determined different, For details, see:

http://rhq-project.org/display/RHQ/Design-Availability+Checking#Design-AvailabilityChecking-GroupAvailability 

- group composite queries incur a slight perf hit as they now return two
  additional counts (although they are no longer called on to perform AVG
  functions).

Test Notes:
Try various group membership scenarios, autogroups and also autoclusters.
Also, the test case above, where avail type changes for existing group
members.

Comment 3 Sunil Kondkar 2012-04-10 11:51:27 UTC

Verified in Version: 4.4.0-SNAPSHOT Build Number: 233eac6

The group list views display correct counts. Also verified disabled icon on group list views, group avail icons and badged group icons.

Comment 4 Heiko W. Rupp 2013-08-31 10:11:50 UTC

Bulk close of old bugs in VERIFIED state.