| Summary: | vzctl version format breaks 0.9x libvirt | ||
|---|---|---|---|
| Product: | [Community] Virtualization Tools | Reporter: | Ilja Livenson <ilja.livenson> |
| Component: | libvirt | Assignee: | Eric Blake <eblake> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | acathrow, berrange, crobinso, dyasny, eblake, xen-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-04-04 20:38:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Not a RHEL issue, switching to upstream bug tracker product Would you mind posting this patch upstream to libvir-list, so it gets more visibility? Is it possible to move the report there? Sorry, I'm not a very frequent bugzilla user - and I made an honest 10 min search for libvirt specific bugzilla (a link on their page leads here). This _is_ the upstream libvirt bug-tracker. It's just that there a lot more developers that read libvir-list (where patches can be directly applied with a single git command), than there are developers that watch the BZ reports (where patches have to be manually copied-and-pasted, taking more effort). Did you find this page? http://libvirt.org/bugs.html Are there any improvements we could make to that page that would make the process easier to understand? (Hint - mention that in your email to libvir-list, as documentation bugs are equally worth fixing). Your patch is now in the following commit for 0.9.12:
commit 37075dfe6ccdb5a257cdd64194b5fdd51458fa8b
Author: Ilja Livenson <ilja.livenson>
Date: Wed Apr 4 14:30:43 2012 -0600
openvz: support vzctl 3.1
https://bugzilla.redhat.com/show_bug.cgi?id=809895
Basically, openvz dropped strict version numbering (3.1 vs 3.1.0),
which caused parsing to fail.
|
Hi, with the latest vzctl the change of a reported version format is breaking libvirt openvz driver ("Could not extract vzctl version"). It used to be in the form of major.minor.micro, now it's just major.minor. patch is quite simple: --- src/openvz/openvz_conf.c +++ src/openvz/openvz_conf.c @@ -99,7 +99,7 @@ openvzExtractVersionInfo(const char *cmd if ((tmp = STRSKIP(tmp, "vzctl version ")) == NULL) goto cleanup; - if (virParseVersionString(tmp, &version, true) < 0) + if (virParseVersionString(tmp, &version, false) < 0) goto cleanup; if (retversion) cheers, Ilya