Bug 809895 - vzctl version format breaks 0.9x libvirt
vzctl version format breaks 0.9x libvirt
Status: CLOSED NEXTRELEASE
Product: Virtualization Tools
Classification: Community
Component: libvirt (Show other bugs)
unspecified
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Eric Blake
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-04 11:35 EDT by Ilja Livenson
Modified: 2014-07-06 15:31 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-04-04 16:38:16 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ilja Livenson 2012-04-04 11:35:09 EDT
Hi,

with the latest vzctl the change of a reported version format is breaking libvirt openvz driver ("Could not extract vzctl version"). It used to be in the form of major.minor.micro, now it's just major.minor.

patch is quite simple:

--- src/openvz/openvz_conf.c
+++ src/openvz/openvz_conf.c
@@ -99,7 +99,7 @@ openvzExtractVersionInfo(const char *cmd
     if ((tmp = STRSKIP(tmp, "vzctl version ")) == NULL)
         goto cleanup;
 
-    if (virParseVersionString(tmp, &version, true) < 0)
+    if (virParseVersionString(tmp, &version, false) < 0)
         goto cleanup;
 
     if (retversion)


cheers,
Ilya
Comment 1 Daniel Berrange 2012-04-04 11:40:57 EDT
Not a RHEL issue, switching to upstream bug tracker product
Comment 2 Eric Blake 2012-04-04 11:43:19 EDT
Would you mind posting this patch upstream to libvir-list@redhat.com, so it gets more visibility?
Comment 3 Ilja Livenson 2012-04-04 12:09:02 EDT
Is it possible to move the report there? Sorry, I'm not a very frequent bugzilla user - and I made an honest 10 min search for libvirt specific bugzilla (a link on their page leads here).
Comment 4 Eric Blake 2012-04-04 12:19:50 EDT
This _is_ the upstream libvirt bug-tracker.  It's just that there a lot more developers that read libvir-list@redhat.com (where patches can be directly applied with a single git command), than there are developers that watch the BZ reports (where patches have to be manually copied-and-pasted, taking more effort).

Did you find this page? http://libvirt.org/bugs.html
Are there any improvements we could make to that page that would make the process easier to understand?  (Hint - mention that in your email to libvir-list, as documentation bugs are equally worth fixing).
Comment 5 Eric Blake 2012-04-04 16:38:16 EDT
Your patch is now in the following commit for 0.9.12:

commit 37075dfe6ccdb5a257cdd64194b5fdd51458fa8b
Author: Ilja Livenson <ilja.livenson@gmail.com>
Date:   Wed Apr 4 14:30:43 2012 -0600

    openvz: support vzctl 3.1
    
    https://bugzilla.redhat.com/show_bug.cgi?id=809895
    
    Basically, openvz dropped strict version numbering (3.1 vs 3.1.0),
    which caused parsing to fail.

Note You need to log in before you can comment on or make changes to this bug.