| Summary: | Ctrl+Space activates ibus regardless of setting in ibus-setup | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matt Chan <talcite> | ||||
| Component: | ibus | Assignee: | fujiwara <tfujiwar> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 16 | CC: | i18n-bugs, shawn.p.huang, talcite, tfujiwar | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ibus-1.4.1-2.fc15 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-05-10 14:25:41 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Matt Chan
2012-04-18 21:46:37 UTC
I cannot reproduce your problem. Could you attach the screenshot of ibus-setup in this bug report? % gnome-screenshot --delay 5 --window I guess you just removed Control+Space in trigger key but it would not work. You need to add another trigger key likes Alt+Shift but not just remove the trigger and also you need to restart ibus-daemon. Created attachment 578631 [details]
screenshot of ibus-setup window
I've had this configuration for several months, but I just discovered the ctrl+space shortcut wasn't disabled. Ibus-daemon should have restarted when I shutdown etc I think. "You need to add another trigger key likes Alt+Shift but not just remove the trigger" Is there a reason that removing the shortcut key by itself doesn't work? (In reply to comment #2) > Created attachment 578631 [details] > screenshot of ibus-setup window OK, when you also put the "Alt+Shift_L" in "Toggle input methods" text entry, I think Control+Space is disabled. Currently the null entry fall back to "Control+Space". Probably this would be a low priority since above way could resolve your problem and this problem is fixed in Fedora 17. Oh ok, as long as it's fixed in F17. Thanks for your help, Matt --- ibus-1.4.1/bus/ibusimpl.c.orig 2012-04-24 11:24:08.599011751 +0900
+++ ibus-1.4.1/bus/ibusimpl.c 2012-04-24 11:43:20.116830546 +0900
@@ -1480,19 +1480,16 @@ _get_engine_desc_hotkeys_with_system (IB
/* If the user customized the trigger key, the trigger key is used for
* any IBus engines. */
- if (_bridge_trigger_keys != NULL &&
- *_bridge_trigger_keys != '\0' &&
- g_strcmp0 (_bridge_trigger_keys, "Control+space") != 0) {
-
+ if (g_strcmp0 (_bridge_trigger_keys, "Control+space") != 0) {
hotkeys = (const gchar *) _bridge_trigger_keys;
} else if (desc) {
hotkeys = ibus_engine_desc_get_hotkeys (desc);
- }
- /* If engine hotkeys are not defined in the compose xml file,
- * IBus trigger keys are used. */
- if (!hotkeys || !*hotkeys) {
+ /* If engine hotkeys are not defined in the compose xml file,
+ * IBus trigger keys are used. */
+ if (!hotkeys || !*hotkeys) {
hotkeys = (const gchar *) _bridge_trigger_keys;
+ }
}
return hotkeys;
@@ -3026,26 +3023,21 @@ _add_engine_hotkey (IBusEngineDesc *engi
/* If the user customized the trigger key, the trigger key is used for
* any IBus engines. */
- if (_bridge_trigger_keys != NULL &&
- *_bridge_trigger_keys != '\0' &&
- g_strcmp0 (_bridge_trigger_keys, "Control+space") != 0) {
-
+ if (g_strcmp0 (_bridge_trigger_keys, "Control+space") != 0) {
hotkeys = (const gchar *) _bridge_trigger_keys;
} else {
hotkeys = ibus_engine_desc_get_hotkeys (engine);
+
+ /* If engine hotkeys are not defined in the compose xml file,
+ * IBus trigger keys are used. */
+ if (!hotkeys || !*hotkeys) {
+ hotkeys = (const gchar *) _bridge_trigger_keys;
+ }
}
#else
hotkeys = ibus_engine_desc_get_hotkeys (engine);
#endif
-#if USE_BRIDGE_HOTKEY
- /* If engine hotkeys are not defined in the compose xml file, IBus trigger
- * keys are used. */
- if (!hotkeys || !*hotkeys) {
- hotkeys = (const gchar *) _bridge_trigger_keys;
- }
-#endif
-
if (!hotkeys || !*hotkeys) {
return;
}
ibus-1.4.1-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ibus-1.4.1-2.fc16 ibus-1.4.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ibus-1.4.1-2.fc15 Package ibus-1.4.1-2.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ibus-1.4.1-2.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-6902/ibus-1.4.1-2.fc15 then log in and leave karma (feedback). ibus-1.4.1-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. ibus-1.4.1-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |