Bug 814803
| Summary: | yppasswd doesn't handle crypt() returning NULL | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Wouters <pwouters> | ||||||
| Component: | yp-tools | Assignee: | Honza Horak <hhorak> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 17 | CC: | hhorak, kklic | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | yp-tools-2.12-9.fc17 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 816201 816203 (view as bug list) | Environment: | |||||||
| Last Closed: | 2012-05-02 20:50:48 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 816201, 816203 | ||||||||
| Attachments: |
|
||||||||
Created attachment 579072 [details]
patch hanlding crypt() returning NULL
As I do not have an existing YP/NIS setup, someone should really test this patch
Thanks for reporting. I've pushed the patch to upstream, applied in Rawhide and will update in F17 soon. Right now, I'm not going to apply the patch and update in F16 and F15 though, unless there is a real use case requiring this fix or some more significant fix. yp-tools-2.12-9.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/yp-tools-2.12-9.fc17 no need for f16, f15. Though RHEL would be nice :) Package yp-tools-2.12-9.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing yp-tools-2.12-9.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-6465/yp-tools-2.12-9.fc17 then log in and leave karma (feedback). yp-tools-2.12-9.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 579069 [details] yp-tools spec file yppasswd doesn't handle crypt() returning NULL, which is possible in fips mode and other corner conditions. It blindly tries to sntrcmp or strdup the return values of crypt() Attached is a patch and updated spec file for rawhide