Bug 814803 - yppasswd doesn't handle crypt() returning NULL
Summary: yppasswd doesn't handle crypt() returning NULL
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: yp-tools
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Honza Horak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 816201 816203
TreeView+ depends on / blocked
 
Reported: 2012-04-20 17:46 UTC by Paul Wouters
Modified: 2012-05-02 20:50 UTC (History)
2 users (show)

Fixed In Version: yp-tools-2.12-9.fc17
Clone Of:
: 816201 816203 (view as bug list)
Environment:
Last Closed: 2012-05-02 20:50:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
yp-tools spec file (8.02 KB, text/x-rpm-spec)
2012-04-20 17:46 UTC, Paul Wouters
no flags Details
patch hanlding crypt() returning NULL (1.96 KB, patch)
2012-04-20 17:48 UTC, Paul Wouters
no flags Details | Diff

Description Paul Wouters 2012-04-20 17:46:49 UTC
Created attachment 579069 [details]
yp-tools spec file

yppasswd doesn't handle crypt() returning NULL, which is possible in fips mode and other corner conditions. It blindly tries to sntrcmp or strdup the return
values of crypt()

Attached is a patch and updated spec file for rawhide

Comment 1 Paul Wouters 2012-04-20 17:48:13 UTC
Created attachment 579072 [details]
patch hanlding crypt() returning NULL

As I do not have an existing YP/NIS setup, someone should really test this patch

Comment 2 Honza Horak 2012-04-23 13:18:49 UTC
Thanks for reporting. I've pushed the patch to upstream, applied in Rawhide and will update in F17 soon.

Right now, I'm not going to apply the patch and update in F16 and F15 though, unless there is a real use case requiring this fix or some more significant fix.

Comment 3 Fedora Update System 2012-04-23 13:20:45 UTC
yp-tools-2.12-9.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/yp-tools-2.12-9.fc17

Comment 4 Paul Wouters 2012-04-24 02:12:48 UTC
no need for f16, f15. Though RHEL would be nice :)

Comment 5 Fedora Update System 2012-04-24 03:17:45 UTC
Package yp-tools-2.12-9.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing yp-tools-2.12-9.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-6465/yp-tools-2.12-9.fc17
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2012-05-02 20:50:48 UTC
yp-tools-2.12-9.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.