Bug 815613

Summary:	coverity fixage implicate geo-replicate brokage
Product:	[Community] GlusterFS	Reporter:	Csaba Henk <csaba>
Component:	geo-replication	Assignee:	Amar Tumballi <amarts>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	high
Version:	mainline	CC:	gluster-bugs, vkoppad, vraman
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-24 17:53:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	817967

Description Csaba Henk 2012-04-24 04:10:28 UTC

Description of problem:

geo-rep does not work... yet again

Version-Release number of selected component (if applicable):


How reproducible:

very much indeed!

Steps to Reproduce:
1. gluster vol geo-rep MASTER SLAVE start
2. gluster vol geo-rep MASTER SLAVE start
3. gluster vol geo-rep MASTER SLAVE start
  
Actual results:

<empty line>
geo-replication command failed
geo-replication start option validation failed
geo-replication command failed
geo-replication start option validation failed
geo-replication command failed

Expected results:

Starting geo-replication session between MASTER & SLAVE has been successful
geo-replication session between MASTER & SLAVE already started
geo-replication command failed
geo-replication session between MASTER & SLAVE already started
geo-replication command failed

Additional info:

Bisected to http://review.gluster.com/3145

Comment 1 Amar Tumballi 2012-04-24 04:30:49 UTC

http://review.gluster.com/#patch,sidebyside,3145,3,xlators/mgmt/glusterd/src/glusterd-geo-rep.c 

Csaba, let me know what should be the behavior when 'fd' and 'pfd' are -1, because the coverity was complaining of possible negative value passed to systemcall.

Comment 2 Anand Avati 2012-04-24 20:32:07 UTC

CHANGE: http://review.gluster.com/3219 (glusterd: command check failure fixes) merged in master by Anand Avati (avati)