Bug 816699
| Summary: | Review Request: rubygem-redcarpet - A fast, safe and extensible Markdown to (X)HTML parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matt Hicks <mhicks> |
| Component: | Package Review | Assignee: | Bryan Kearney <bkearney> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkearney, notting, package-review |
| Target Milestone: | --- | Flags: | bkearney:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-07 23:04:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matt Hicks
2012-04-26 17:54:19 UTC
NEEDSWORK
* General
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - License files are installed as %doc
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - BuildRoot value (one of the recommended values)
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - 'Requires' create needed unowned directories
OK - Package builds successfully on i386 and x86_64 (mock)
OK - BuildRequires sufficient
OK - File permissions set properly
NACK - Macro usage is consistent
Several of the macros exist already (http://fedoraproject.org/wiki/Packaging:Ruby#Macros)
WARN - rpmlint is silent
Some issues from the binary. Might be nice to move these to a devel.
* Package a rubygem
OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package requires gem dependencies correctly
OK - Package owns its directories under %gemdir
** arch rubygem
OK - No arch specific content in %{gemdir}
OK - Defines ruby_sitearch from rbconfig
OK - arch specific content moved to %{ruby_sitearch}
Updated to only conditionalize el6: Spec URL: http://matthicksj.fedorapeople.org/reviews/rubygem-redcarpet.spec SRPM URL: http://matthicksj.fedorapeople.org/reviews/rubygem-redcarpet-2.1.1-1.fc16.src.rpm That look okay? New Package SCM Request ======================= Package Name: rubygem-redcarpet Short Description: RedCarpet is a fast, safe and extensible Markdown to (X)HTML parser. Owners: matthicksj Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). rubygem-redcarpet-2.1.1-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-redcarpet-2.1.1-5.el6 rubygem-redcarpet-2.1.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-redcarpet-2.1.1-4.fc16 rubygem-redcarpet-2.1.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-redcarpet-2.1.1-4.fc17 rubygem-redcarpet-2.1.1-4.fc16 has been pushed to the Fedora 16 testing repository. rubygem-redcarpet-2.1.1-4.fc16 has been pushed to the Fedora 16 stable repository. rubygem-redcarpet-2.1.1-4.fc17 has been pushed to the Fedora 17 stable repository. rubygem-redcarpet-2.1.1-5.el6 has been pushed to the Fedora EPEL 6 stable repository. |