Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://matthicksj.fedorapeople.org/reviews/rubygem-redcarpet.spec SRPM URL: http://matthicksj.fedorapeople.org/reviews/rubygem-redcarpet-2.1.1-1.fc16.src.rpm Description: RedCarpet is a fast, safe and extensible Markdown to (X)HTML parser. Note: Wasn't sure about the devel-file-in-non-devel-package warnings. I didn't see any rubygems that split those out into a -devel package, so I figured they were okay. $ rpmlint -v /var/lib/mock/fedora-17-i386/result/rubygem-redcarpet-2.1.1-1.fc17.i686.rpm rubygem-redcarpet.i686: I: checking rubygem-redcarpet.i686: I: checking-url http://github.com/tanoku/redcarpet (timeout 10 seconds) rubygem-redcarpet.i686: W: no-soname /usr/lib/gems/exts/redcarpet-2.1.1/lib/redcarpet.so rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/html_smartypants.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/stack.h rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/html_blocks.h rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/html.h rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/html.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/rc_render.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/buffer.h rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/buffer.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/houdini_href_e.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/houdini.h rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/markdown.h rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/rc_markdown.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/markdown.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/stack.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/redcarpet.h rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/autolink.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/houdini_html_e.c rubygem-redcarpet.i686: W: devel-file-in-non-devel-package /usr/share/gems/gems/redcarpet-2.1.1/ext/redcarpet/autolink.h rubygem-redcarpet.i686: W: no-manual-page-for-binary redcarpet 1 packages and 0 specfiles checked; 0 errors, 20 warnings. $ rpmlint -v /var/lib/mock/fedora-17-i386/result/rubygem-redcarpet-doc-2.1.1-1.fc17.noarch.rpm rubygem-redcarpet-doc.noarch: I: checking rubygem-redcarpet-doc.noarch: I: checking-url http://github.com/tanoku/redcarpet (timeout 10 seconds) rubygem-redcarpet-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/redcarpet-2.1.1/ri/cache.ri 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
NEEDSWORK * General OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used OK - Source md5sum matches upstream OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly NACK - Macro usage is consistent Several of the macros exist already (http://fedoraproject.org/wiki/Packaging:Ruby#Macros) WARN - rpmlint is silent Some issues from the binary. Might be nice to move these to a devel. * Package a rubygem OK - Package is named rubygem-%{gemname} OK - Source points to full URL of gem OK - Package version identical with gem version OK - Package Requires and BuildRequires rubygems OK - Package requires gem dependencies correctly OK - Package owns its directories under %gemdir ** arch rubygem OK - No arch specific content in %{gemdir} OK - Defines ruby_sitearch from rbconfig OK - arch specific content moved to %{ruby_sitearch}
Updated to only conditionalize el6: Spec URL: http://matthicksj.fedorapeople.org/reviews/rubygem-redcarpet.spec SRPM URL: http://matthicksj.fedorapeople.org/reviews/rubygem-redcarpet-2.1.1-1.fc16.src.rpm That look okay?
New Package SCM Request ======================= Package Name: rubygem-redcarpet Short Description: RedCarpet is a fast, safe and extensible Markdown to (X)HTML parser. Owners: matthicksj Branches: f16 f17 el6 InitialCC:
Git done (by process-git-requests).
rubygem-redcarpet-2.1.1-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-redcarpet-2.1.1-5.el6
rubygem-redcarpet-2.1.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-redcarpet-2.1.1-4.fc16
rubygem-redcarpet-2.1.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-redcarpet-2.1.1-4.fc17
rubygem-redcarpet-2.1.1-4.fc16 has been pushed to the Fedora 16 testing repository.
rubygem-redcarpet-2.1.1-4.fc16 has been pushed to the Fedora 16 stable repository.
rubygem-redcarpet-2.1.1-4.fc17 has been pushed to the Fedora 17 stable repository.
rubygem-redcarpet-2.1.1-5.el6 has been pushed to the Fedora EPEL 6 stable repository.