Bug 816840

Summary:	Enable return of errstr for peer probe/derobe
Product:	[Community] GlusterFS	Reporter:	Kaushal <kaushal>
Component:	glusterd	Assignee:	Kaushal <kaushal>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Rahul Hinduja <rhinduja>
Severity:	medium	Docs Contact:
Priority:	high
Version:	3.3-beta	CC:	gluster-bugs, rfortier
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-24 17:40:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	817967

Description Kaushal 2012-04-27 07:17:34 UTC

Presently on  peer probe glusterd returns only an errno to cli, which cli uses to show the required message. Enhancements to peer probe behavior are being planned which require that glusterd also return an errstr.

Comment 1 Anand Avati 2012-05-19 02:44:19 UTC

CHANGE: http://review.gluster.com/3262 (glusterd, cli: Enable errstr for peer probe) merged in master by Anand Avati (avati)

Comment 2 Anand Avati 2012-05-19 02:45:54 UTC

CHANGE: http://review.gluster.com/3307 (glusterd,cli: Enable errstr for peer detach) merged in master by Anand Avati (avati)

Comment 3 Rahul Hinduja 2012-06-04 05:58:26 UTC

Verified by looking into the "gd1_mgmt_probe_rsp" code of qa32 and qa45.

Difference is of the "char *op_errstr" in qa45. Marking as verified.

Code snippet:
============

qa32:
====

struct gd1_mgmt_probe_rsp {
        u_char uuid[16];
        char *hostname;
        int port;
        int op_ret;
        int op_errno;
};

qa45:
====

struct gd1_mgmt_probe_rsp {
        u_char uuid[16];
        char *hostname;
        int port;
        int op_ret;
        int op_errno;
        char *op_errstr;
};