Bug 816840 - Enable return of errstr for peer probe/derobe
Summary: Enable return of errstr for peer probe/derobe
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: 3.3-beta
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
Assignee: Kaushal
QA Contact: Rahul Hinduja
URL:
Whiteboard:
Depends On:
Blocks: 817967
TreeView+ depends on / blocked
 
Reported: 2012-04-27 07:17 UTC by Kaushal
Modified: 2015-12-01 16:45 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.4.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-24 17:40:58 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaushal 2012-04-27 07:17:34 UTC
Presently on  peer probe glusterd returns only an errno to cli, which cli uses to show the required message. Enhancements to peer probe behavior are being planned which require that glusterd also return an errstr.

Comment 1 Anand Avati 2012-05-19 02:44:19 UTC
CHANGE: http://review.gluster.com/3262 (glusterd, cli: Enable errstr for peer probe) merged in master by Anand Avati (avati)

Comment 2 Anand Avati 2012-05-19 02:45:54 UTC
CHANGE: http://review.gluster.com/3307 (glusterd,cli: Enable errstr for peer detach) merged in master by Anand Avati (avati)

Comment 3 Rahul Hinduja 2012-06-04 05:58:26 UTC
Verified by looking into the "gd1_mgmt_probe_rsp" code of qa32 and qa45.

Difference is of the "char *op_errstr" in qa45. Marking as verified.

Code snippet:
============

qa32:
====

struct gd1_mgmt_probe_rsp {
        u_char uuid[16];
        char *hostname;
        int port;
        int op_ret;
        int op_errno;
};

qa45:
====

struct gd1_mgmt_probe_rsp {
        u_char uuid[16];
        char *hostname;
        int port;
        int op_ret;
        int op_errno;
        char *op_errstr;
};


Note You need to log in before you can comment on or make changes to this bug.