Bug 818318

Summary: Review Request: php-digitalsandwich-Phake - Phake is a PHP mocking framework that is based on Mockito
Product: [Fedora] Fedora Reporter: Christof Damian <christof>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-26 00:49:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 818317    
Bug Blocks:    
Attachments:
Description Flags
review.txt fedora: review?

Description Christof Damian 2012-05-02 18:39:48 UTC 
Spec URL: http://rpms.damian.net/SPECS/php-digitalsandwich-Phake.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-digitalsandwich-Phake-1.0.2-1.fc16.src.rpm
Description: Phake is a framework for PHP that aims to provide mock objects, test doubles and method stubs.
Comment 1 Remi Collet 2012-05-24 16:47:09 UTC 
Created attachment 586673 [details]
review.txt

Generated by fedora-review 0.1.3
Comment 2 Remi Collet 2012-05-24 16:48:52 UTC 
Should
- request upstream to add a LICENSE file in the archive installed with role="doc"
- clean EL-5 stuff (not an issue for me while EL-5 is not EOL)


*** APPROVED ***
Comment 3 Remi Collet 2012-05-24 17:01:52 UTC 
Just see https://github.com/mlively/Phake

So you can request to add CHANGELOG, LICENSE and README with role="doc" and to add tests folder as role="test" (next step will be to add a %check in the spec to run this test suite), as this files are already there.

Or course, this doesn't change the "APPROVED" state
Comment 4 Christof Damian 2012-05-24 18:01:14 UTC 
(In reply to comment #3)
> Just see https://github.com/mlively/Phake
> 
> So you can request to add CHANGELOG, LICENSE and README with role="doc" and
> to add tests folder as role="test" (next step will be to add a %check in the
> spec to run this test suite), as this files are already there.
> 
> Or course, this doesn't change the "APPROVED" state

thanks. 

I have created an issue on github: https://github.com/mlively/Phake/issues/64 and might create a pull request fixing this too.
Comment 5 Christof Damian 2012-05-24 18:05:04 UTC 
New Package SCM Request
=======================
Package Name: php-digitalsandwich-Phake
Short Description: Phake is a PHP mocking framework that is based on Mockito
Owners: cdamian
Branches: el6 f16 f17
InitialCC:
Comment 6 Gwyn Ciesla 2012-05-24 19:15:40 UTC 
Git done (by process-git-requests).
Comment 7 Fedora Update System 2012-06-15 13:22:46 UTC 
php-digitalsandwich-Phake-1.0.2-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/php-digitalsandwich-Phake-1.0.2-1.fc16
Comment 8 Fedora Update System 2012-06-16 00:03:25 UTC 
php-digitalsandwich-Phake-1.0.2-1.fc16 has been pushed to the Fedora 16 testing repository.
Comment 9 Fedora Update System 2012-06-26 00:49:55 UTC 
php-digitalsandwich-Phake-1.0.2-1.fc16 has been pushed to the Fedora 16 stable repository.