Spec URL: http://rpms.damian.net/SPECS/php-digitalsandwich-Phake.spec SRPM URL: http://rpms.damian.net/SRPMS/php-digitalsandwich-Phake-1.0.2-1.fc16.src.rpm Description: Phake is a framework for PHP that aims to provide mock objects, test doubles and method stubs.
Created attachment 586673 [details] review.txt Generated by fedora-review 0.1.3
Should - request upstream to add a LICENSE file in the archive installed with role="doc" - clean EL-5 stuff (not an issue for me while EL-5 is not EOL) *** APPROVED ***
Just see https://github.com/mlively/Phake So you can request to add CHANGELOG, LICENSE and README with role="doc" and to add tests folder as role="test" (next step will be to add a %check in the spec to run this test suite), as this files are already there. Or course, this doesn't change the "APPROVED" state
(In reply to comment #3) > Just see https://github.com/mlively/Phake > > So you can request to add CHANGELOG, LICENSE and README with role="doc" and > to add tests folder as role="test" (next step will be to add a %check in the > spec to run this test suite), as this files are already there. > > Or course, this doesn't change the "APPROVED" state thanks. I have created an issue on github: https://github.com/mlively/Phake/issues/64 and might create a pull request fixing this too.
New Package SCM Request ======================= Package Name: php-digitalsandwich-Phake Short Description: Phake is a PHP mocking framework that is based on Mockito Owners: cdamian Branches: el6 f16 f17 InitialCC:
Git done (by process-git-requests).
php-digitalsandwich-Phake-1.0.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-digitalsandwich-Phake-1.0.2-1.fc16
php-digitalsandwich-Phake-1.0.2-1.fc16 has been pushed to the Fedora 16 testing repository.
php-digitalsandwich-Phake-1.0.2-1.fc16 has been pushed to the Fedora 16 stable repository.