Bug 818952

Summary: basic c:group support for BaseComponent and AS7 plugin is not currently working
Product: [Other] RHQ Project Reporter: Simeon Pinder <spinder>
Component: PluginsAssignee: Simeon Pinder <spinder>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4CC: hrupp
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 823029 (view as bug list) Environment:
Last Closed: 2013-09-01 19:19:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 707223, 823029    
Attachments:
Description Flags
patch for edit/load c:group support.
none
itests for c:group checking. none

Description Simeon Pinder 2012-05-04 13:26:07 UTC 
Description of problem:
Within the AS7 plugin descriptor if you group arbitrary elements using <c:group> tags not requiring special handling then the ConfigurationFacet.loadConfiguration and ConfigurationFacet.updateConfiguration mechanisms do not work properly. The UI will display the grouped elements correctly however.

Version-Release number of selected component (if applicable):


How reproducible:
Always.

Steps to Reproduce:
1. Modify the plugin to use <c:group without using AS7 special handling of c:groups and rebuild/redeploy the plugin.
2. To test with Modcluster, run EAP ER6 with one of the -ha profiles and navigate to the Configuration tab.

  
Actual results:
The components will be correctly organized/grouped but not set correctly.

Expected results:
The components should be correctly organized/grouped and set/updated correctly.

Additional info:
Comment 1 Simeon Pinder 2012-05-04 17:39:55 UTC 
Created attachment 582171 [details]
patch for edit/load c:group support.
Comment 2 Simeon Pinder 2012-05-07 13:29:09 UTC 
Setting NeedInfo on heiko so he can review the patch to see if I nicked anything.
Comment 3 Mike Foley 2012-05-08 19:33:30 UTC 
per BZ triage ... crouch, loleary, foley
Comment 4 Heiko W. Rupp 2012-05-08 20:01:15 UTC 
Simeon, can you please also add tests for this (ConfigLoadTest, ConfigUpdateTest)?
Comment 5 Simeon Pinder 2012-05-11 20:06:27 UTC 
Created attachment 583917 [details]
itests for c:group checking.
Comment 6 Simeon Pinder 2012-05-11 20:08:16 UTC 
Heiko, I've added tests for the ConfigLoad and ConfigUpdate.  Can you review the patches so that I can check these into master?

Setting NeedInfo on heiko but leaving this on_dev.
Comment 7 Heiko W. Rupp 2012-05-15 19:17:25 UTC 
Go ahead
Comment 8 Simeon Pinder 2012-05-18 20:15:24 UTC 
Committed to master: 
edc0315a43f
71442395543

Moving this to ON_QA.
Comment 9 Heiko W. Rupp 2013-09-01 19:19:09 UTC 
Bulk closing of BZs that have no target version set, but which are ON_QA for more than a year and thus are in production for a long time.