Bug 818952 - basic c:group support for BaseComponent and AS7 plugin is not currently working
Summary: basic c:group support for BaseComponent and AS7 plugin is not currently working
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Plugins
Version: 4.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Simeon Pinder
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks: as7-plugin 823029
TreeView+ depends on / blocked
 
Reported: 2012-05-04 13:26 UTC by Simeon Pinder
Modified: 2013-09-01 19:19 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 823029 (view as bug list)
Environment:
Last Closed: 2013-09-01 19:19:09 UTC
Embargoed:


Attachments (Terms of Use)
patch for edit/load c:group support. (8.17 KB, text/plain)
2012-05-04 17:39 UTC, Simeon Pinder
no flags Details
itests for c:group checking. (13.34 KB, text/plain)
2012-05-11 20:06 UTC, Simeon Pinder
no flags Details

Description Simeon Pinder 2012-05-04 13:26:07 UTC
Description of problem:
Within the AS7 plugin descriptor if you group arbitrary elements using <c:group> tags not requiring special handling then the ConfigurationFacet.loadConfiguration and ConfigurationFacet.updateConfiguration mechanisms do not work properly. The UI will display the grouped elements correctly however.

Version-Release number of selected component (if applicable):


How reproducible:
Always.

Steps to Reproduce:
1. Modify the plugin to use <c:group without using AS7 special handling of c:groups and rebuild/redeploy the plugin.
2. To test with Modcluster, run EAP ER6 with one of the -ha profiles and navigate to the Configuration tab.

  
Actual results:
The components will be correctly organized/grouped but not set correctly.

Expected results:
The components should be correctly organized/grouped and set/updated correctly.

Additional info:

Comment 1 Simeon Pinder 2012-05-04 17:39:55 UTC
Created attachment 582171 [details]
patch for edit/load c:group support.

Comment 2 Simeon Pinder 2012-05-07 13:29:09 UTC
Setting NeedInfo on heiko so he can review the patch to see if I nicked anything.

Comment 3 Mike Foley 2012-05-08 19:33:30 UTC
per BZ triage ... crouch, loleary, foley

Comment 4 Heiko W. Rupp 2012-05-08 20:01:15 UTC
Simeon, can you please also add tests for this (ConfigLoadTest, ConfigUpdateTest)?

Comment 5 Simeon Pinder 2012-05-11 20:06:27 UTC
Created attachment 583917 [details]
itests for c:group checking.

Comment 6 Simeon Pinder 2012-05-11 20:08:16 UTC
Heiko, I've added tests for the ConfigLoad and ConfigUpdate.  Can you review the patches so that I can check these into master?

Setting NeedInfo on heiko but leaving this on_dev.

Comment 7 Heiko W. Rupp 2012-05-15 19:17:25 UTC
Go ahead

Comment 8 Simeon Pinder 2012-05-18 20:15:24 UTC
Committed to master: 
edc0315a43f
71442395543

Moving this to ON_QA.

Comment 9 Heiko W. Rupp 2013-09-01 19:19:09 UTC
Bulk closing of BZs that have no target version set, but which are ON_QA for more than a year and thus are in production for a long time.


Note You need to log in before you can comment on or make changes to this bug.