Bug 819180
Summary: | Review Request: kdesrc-build - A tool to allow you to easily build KDE from its source repositories | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gregor Tätzner <gregor> |
Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jreznik, kevin, notting, package-review, rdieter |
Target Milestone: | --- | Flags: | jreznik:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-06-22 08:29:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 656997 |
Description
Gregor Tätzner
2012-05-05 12:03:02 UTC
RPMLINT output clean rpmlint kdesrc-build.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint kdesrc-build-1.14.1-1.fc14.src.rpm kdesrc-build.src: W: spelling-error %description -l en_US kdesvn 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint kdesrc-build-1.14.1-1.fc14.noarch.rpm kdesrc-build.noarch: W: spelling-error %description -l en_US kdesvn 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Name: ok Version: ok Release: ok Summary: ok (could be a little bit shorter with brief description but) License: ok (as found in LICENSE file) URL: ok Source: BuildRequires: ok BuildArch: ok, noarch Description: ok Macros uses consistently: ok Documentation: COPYING.LIB is missing For tests you should use the %check section [1]. I'd let the desktop-file-install for desktop file even it's hidden. I don't see any icon installed so the %post, %postun and %posttrans scriptlets are useless here (to recreate icon cache). [1] http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25check_section Ah, sorry. Source: ok (md5sum 34ecab2c30556bcdb7a2ac30281a46f7 kdesrc-build-1.14.1.tar.bz2) Spec URL: http://brummbq.fedorapeople.org/kdesrc-build.spec SRPM URL: http://brummbq.fedorapeople.org/kdesrc-build-1.14.1-2.fc16.src.rpm That was quick, thank you Jaroslav! You have earned a review coupon :) 2 Days ago upstream released a new version. But I can't update my package for the moment because a) not all tests are succeeding b) the tool doesn't work on fedora, at least for me (complaining about missing qmake?!) just for information. I'm going to fill some bug reports. With our system Qt, it needs to use qmake-qt4, not just qmake. We have figured out all issues. So here is the new crispy and hot bugfix release. Spec URL: http://brummbq.fedorapeople.org/kdesrc-build.spec SRPM URL: http://brummbq.fedorapeople.org/kdesrc-build-1.15.1-1.fc16.src.rpm rpmlint kdesrc-build-1.15.1-1.fc16.src.rpm kdesrc-build.src: W: spelling-error %description -l en_US kdesvn kdesrc-build.src:80: W: macro-in-%changelog %check kdesrc-build.src: W: invalid-url Source0: http://kdesrc-build.kde.org/releases/kdesrc-build-1.15.1.tar.xz HTTP Error 404: Not Found it's probably better to use standard ftp://ftp.kde.org/pub/kde/stable/kdesrc-build/1.15.1/src/ md5sum 9469a5fcc585e0f37cc295b44a0d36e1 It looks ok, just fix the sources url. Spec URL: http://brummbq.fedorapeople.org/kdesrc-build.spec SRPM URL: http://brummbq.fedorapeople.org/kdesrc-build-1.15.1-2.fc16.src.rpm whoops...silly mistake Looks ok for me, thanks. APPROVED New Package SCM Request ======================= Package Name: kdesrc-build Short Description: A tool to allow you to easily build KDE from its source repositories Owners: brummbq Branches: f16 f17 InitialCC: Jaroslav, please set review flag to +, and then Gregor, re-set the cs flag. Thanks! Done, review flag set back to +. Git done (by process-git-requests). Thanks, and also please take ownership of review BZs in the future. (In reply to comment #13) > Git done (by process-git-requests). > > Thanks, and also please take ownership of review BZs in the future. Ah, I understand it now - I was assignee, the review flag was set to + but it was reset by Gregor. Gregor, for next review - do not touch assignee and state during the review + review flag. Thanks. kdesrc-build-1.15.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kdesrc-build-1.15.1-2.fc17 kdesrc-build-1.15.1-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kdesrc-build-1.15.1-2.fc16 kdesrc-build-1.15.1-2.fc17 has been pushed to the Fedora 17 testing repository. kdesrc-build-1.15.1-2.fc16 has been pushed to the Fedora 16 stable repository. kdesrc-build-1.15.1-2.fc17 has been pushed to the Fedora 17 stable repository. |