Bug 819591

Summary: Package Review: cvsps
Product: [Fedora] Fedora Reporter: Michal Luscon <mluscon>
Component: Package ReviewAssignee: Honza Horak <hhorak>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: hhorak, notting, package-review
Target Milestone: ---Flags: hhorak: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-10 12:20:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michal Luscon 2012-05-07 16:14:41 UTC
Checked git commit:
048e66bf82d60a701cc2b622f4721779c3372cfb

YES source files match upstream - cvsps-2.2b1.tar.gz
YES package meets naming 
NO package meets versioning guidelines. Pre-version should be marked as b.1 instead of b1.
YES specfile is properly named, is cleanly written and uses macros consistently.
YES dist tag is present.
YES clean section and buildroot are present
YES license field matches the actual license
YES license is open source-compatible 
YES license text included in package
YES latest version is being packaged
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES package builds in mock
YES debuginfo package looks complete.
NO rpmlint is silent - incorrect-fsf-address /usr/share/doc/cvsps-2.2/COPYING
YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES scriptlets must be sane.
YES code, not content.
N/A large documentation files must go in a -doc subpackage.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.

Comment 1 Ville Skyttä 2012-05-08 07:49:39 UTC
(In reply to comment #0)

> NO package meets versioning guidelines. Pre-version should be marked as b.1
> instead of b1.

This is incorrect, b1 is fine here as it's preceded by 0.x.

Comment 2 Honza Horak 2012-05-09 10:29:45 UTC
(In reply to comment #0)
> NO rpmlint is silent - incorrect-fsf-address /usr/share/doc/cvsps-2.2/COPYING

I've reported this to upstream.

Comment 3 Honza Horak 2012-05-10 12:20:30 UTC
It seems all inconsistencies are addressed, so closing.